Bug 37283

Summary: t/db_dependent/selenium/authentication.t is failing
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: Test SuiteAssignee: Pedro Amorim <pedro.amorim>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: caroline.cyr-la-rose, fridolin.somers, jonathan.druart, lucas, m.de.rooy, martin.renvoize, nick, pedro.amorim, victor
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06
Circulation function:
Bug Depends on: 37056    
Bug Blocks:    
Attachments: Bug 37283: Update expected error page title
Bug 37283: Update expected error page title
Bug 37283: Update expected error page title

Description Katrin Fischer 2024-07-09 08:59:43 UTC
It's failing on D12 in Jenkins, but also locally in ktd:

t/db_dependent/selenium/authentication.t .. 
        #   Failed test 'Patron cannot access svc script where circulate permissions are required'
        #   at t/db_dependent/selenium/authentication.t line 135.
        #                   'An Error Occurred'
        #     doesn't match '(?^u:Error 500)'
        # Looks like you failed 1 test of 17.

    #   Failed test 'not authorized'
    #   at t/db_dependent/selenium/authentication.t line 140.
    # Looks like you failed 1 test of 7.
Comment 1 Pedro Amorim 2024-07-09 09:49:53 UTC
Created attachment 168637 [details] [review]
Bug 37283: Update expected error page title

I dont know how this was working before, but if we do:
cat -n /usr/share/perl5/HTTP/Response.pm | grep Error

We notice that error_as_HTML returns 'An Error Occurred' for page title and that is what we should be expecting?
Comment 2 David Nind 2024-07-09 10:04:30 UTC
Created attachment 168639 [details] [review]
Bug 37283: Update expected error page title

I dont know how this was working before, but if we do:
cat -n /usr/share/perl5/HTTP/Response.pm | grep Error

We notice that error_as_HTML returns 'An Error Occurred' for page title and that is what we should be expecting?

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Jonathan Druart 2024-07-09 11:51:24 UTC
Created attachment 168645 [details] [review]
Bug 37283: Update expected error page title

I dont know how this was working before, but if we do:
cat -n /usr/share/perl5/HTTP/Response.pm | grep Error

We notice that error_as_HTML returns 'An Error Occurred' for page title and that is what we should be expecting?

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Caused by bug 37056.
Comment 4 Katrin Fischer 2024-07-09 12:57:08 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 5 Lucas Gass (lukeg) 2024-11-18 18:07:47 UTC
Backported to 24.05.x for upcoming 24.05.06
Comment 6 Fridolin Somers 2024-12-06 08:21:03 UTC
Depends on Bug 37056 not in 23.11.x
Comment 7 Caroline Cyr La Rose 2025-04-18 19:13:24 UTC
Bug fix, nothing to add/edit in the manual.