Bug 37283 - t/db_dependent/selenium/authentication.t is failing
Summary: t/db_dependent/selenium/authentication.t is failing
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Pedro Amorim
QA Contact: Testopia
URL:
Keywords: RM_priority
Depends on: 37056
Blocks:
  Show dependency treegraph
 
Reported: 2024-07-09 08:59 UTC by Katrin Fischer
Modified: 2024-07-09 12:57 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 37283: Update expected error page title (1.56 KB, patch)
2024-07-09 09:49 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 37283: Update expected error page title (1.61 KB, patch)
2024-07-09 10:04 UTC, David Nind
Details | Diff | Splinter Review
Bug 37283: Update expected error page title (1.70 KB, patch)
2024-07-09 11:51 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2024-07-09 08:59:43 UTC
It's failing on D12 in Jenkins, but also locally in ktd:

t/db_dependent/selenium/authentication.t .. 
        #   Failed test 'Patron cannot access svc script where circulate permissions are required'
        #   at t/db_dependent/selenium/authentication.t line 135.
        #                   'An Error Occurred'
        #     doesn't match '(?^u:Error 500)'
        # Looks like you failed 1 test of 17.

    #   Failed test 'not authorized'
    #   at t/db_dependent/selenium/authentication.t line 140.
    # Looks like you failed 1 test of 7.
Comment 1 Pedro Amorim 2024-07-09 09:49:53 UTC
Created attachment 168637 [details] [review]
Bug 37283: Update expected error page title

I dont know how this was working before, but if we do:
cat -n /usr/share/perl5/HTTP/Response.pm | grep Error

We notice that error_as_HTML returns 'An Error Occurred' for page title and that is what we should be expecting?
Comment 2 David Nind 2024-07-09 10:04:30 UTC
Created attachment 168639 [details] [review]
Bug 37283: Update expected error page title

I dont know how this was working before, but if we do:
cat -n /usr/share/perl5/HTTP/Response.pm | grep Error

We notice that error_as_HTML returns 'An Error Occurred' for page title and that is what we should be expecting?

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Jonathan Druart 2024-07-09 11:51:24 UTC
Created attachment 168645 [details] [review]
Bug 37283: Update expected error page title

I dont know how this was working before, but if we do:
cat -n /usr/share/perl5/HTTP/Response.pm | grep Error

We notice that error_as_HTML returns 'An Error Occurred' for page title and that is what we should be expecting?

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Caused by bug 37056.
Comment 4 Katrin Fischer 2024-07-09 12:57:08 UTC
Pushed for 24.11!

Well done everyone, thank you!