Summary: | Generate next button in serials not working | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Serials | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | RESOLVED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | normal | ||
Priority: | P5 - low | CC: | Chip.Halvorsen, cj.lynce, danielle.elder, david, fridolin.somers, kelly |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes the 'Generate next' button when receiving serials so that it now works as expected. Before this fix, nothing happened when clicking the button. (This is related to the CSRF changes added in Koha 24.05 to improve form security.)
|
Version(s) released in: |
24.11.00,24.05.04
|
Circulation function: | |||
Attachments: |
Bug 37294: Add modal to generate next
Bug 37294: Add modal to generate next Bug 37294: Add modal to generate next |
Description
Lucas Gass (lukeg)
2024-07-09 20:04:23 UTC
Created attachment 168685 [details] [review] Bug 37294: Add modal to generate next To test: 1. Serials -> Create or find a subscription 2. Receive the subscription 3. Save 4. Click 'Generate next' 5. Nothing happens 6. APPLY PATCH 7. Try again, now the "Generate next" button should work as expected. Created attachment 168727 [details] [review] Bug 37294: Add modal to generate next To test: 1. Serials -> Create or find a subscription 2. Receive the subscription 3. Save 4. Click 'Generate next' 5. Nothing happens 6. APPLY PATCH 7. Try again, now the "Generate next" button should work as expected. Signed-off-by: Kelly <kelly@bywatersoutions.com> Hi Kelly. It looks like you signed off, but the status is still "Needs Signoff". If you can update the status, you will get the credit on the dashboard. 8-) David Got it! Thanks David! Created attachment 169105 [details] [review] Bug 37294: Add modal to generate next To test: 1. Serials -> Create or find a subscription 2. Receive the subscription 3. Save 4. Click 'Generate next' 5. Nothing happens 6. APPLY PATCH 7. Try again, now the "Generate next" button should work as expected. Signed-off-by: Kelly <kelly@bywatersoutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Great to see this turning into a Modal whilst also fixing the reported problem, thanks Lucas Passing QA making_things_more_consistent++ Pushed for 24.11! Well done everyone, thank you! This is another bug we'd love to see squashed in 24.05. Thx! Another plea for 24.05 backporting. This patch includes strings, so I can't backport it for 24.05.02 as we are already in string freeze. I'll pick it up first thing in the .03 cycle. Backported to 24.05.x for upcoming 24.05.04 Looks like this is CRSF related, not for 23.11.x Fixed a bug, nothing to document. |