| Summary: | Renewal due date and renew as unseen fields not respected when renewing an item from the patron account | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
| Component: | Circulation | Assignee: | Emily Lamancusa (emlam) <emily.lamancusa> |
| Status: | Needs documenting --- | QA Contact: | Kyle M Hall (khall) <kyle> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | Chip.Halvorsen, cj.lynce, david, ddaghita, emily.lamancusa, fridolin.somers, gmcharlt, isabel.pineda, kebliss, kyle.m.hall, kyle, lucas, mik |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This fixes two issues when renewing items for patrons in the staff interface (Patrons > selected patron > Check out > Checkouts table). The "Renew as unseen" checkbox and the custom renewal due date field were both ignored. With these changes, the functionality to change the renewal due date and process a renewal as an unseen renewal once again work as intended.
|
Version(s) released in: |
24.11.00,24.05.02
|
| Circulation function: | |||
| Bug Depends on: | 36084 | ||
| Bug Blocks: | 36192, 37189 | ||
| Attachments: |
Bug 37332: Handle custom renewal date parameter in svc
Bug 37332: Fix unseen and customer renewal date parameters in svc Bug 37332: Fix unseen and customer renewal date parameters in svc Bug 37332: Fix unseen and customer renewal date parameters in svc |
||
|
Description
Andrew Fuerste-Henry
2024-07-11 18:27:07 UTC
I am able to manually set a due date when renewing from the Renew page in the circulation module. We are experiencing the same behavior on 24.05 when renewing from the user's account page.
To reproduce
1. Check out item to borrower
1-2. For greater identification of issue, select a custom
due date for checkout that does not match the circ rule.
2. Access the borrowers account and view current checkouts.
3. Check box next to item for renew
3-1. If restrict early renewals, Ensure you have a circ rule
that allows for early renewal, or AllowRenewalLimitOverride
is allow, and check the override renewal restrictions box
4. Specify a custom due date in 'Renewal Due Date' box - chose a date
that does not match the circ rule
5. Click 'Renew selected items'
6. Access the borrowers account and view current checkouts.
Note: that the new due date does not match the one we selected, and
instead matches the date calculated by the circ rule
*** This bug has been marked as a duplicate of bug 36459 *** Lucas and I have discussed this and agreed it is distinct from 35459 *** Bug 36407 has been marked as a duplicate of this bug. *** Created attachment 169047 [details] [review] Bug 37332: Handle custom renewal date parameter in svc To test: 1. Check out an item to a patron 2. In the checkouts table on that patron's account, check the "Renew" checkbox for that item 3. Select a custom renewal date using the Renewal due date flatpicker 4. Click Renew selected items --> The item renews, but its new due date follows the renewal period specified in the circulation rules, regardless of what date was entered in the Renewal due date field 5. Enter another custom renewal date and renew checkout with the Renew all button --> Same result 6. Apply patch and restart_all 7. Repeat test plan --> Custom renewal date is now respected Created attachment 169048 [details] [review] Bug 37332: Fix unseen and customer renewal date parameters in svc To test: 0. Enable unseen renewals i. Set the system preference UnseenRenewals to Allowed ii. Edit the circulation rules to specify the maximum number of unseen renewals allowed 1. Check out an item to a patron 2. In the checkouts table on that patron's account, check the "Renew" checkbox for that item 3. Select a custom renewal date using the Renewal due date flatpicker 4. Check the checkbox labeled "Renew as unseen if appropriate" 4. Click Renew selected items --> The item renews, but its new due date follows the renewal period specified in the circulation rules, regardless of what date was entered in the Renewal due date field --> The checkout still has all of its unseen renewals remaining, indicating that the renewal was not processed as an unseen renewal 5. Enter another custom renewal date and renew checkout with the Renew all button --> Same result 6. Apply patch and restart_all 7. Repeat test plan --> Custom renewal date is now respected --> Number of unseen renewals remaining decreases when "Renew as unseen" checkbox is checked 8. Renew the item with the "Renew as unseen" checkbox unchecked --> Confirm that number of unseen renewals is reset (i.e. the checkout once again has all of its unseen renewals remaining), indicating that the renewal was processed as a "seen" renewal Looks like the cause was bug 36084 - the line to get the due_date and unseen parameters in the new svc handler was commented out. Uncommenting it seems to fix the issue (plus the related issue where the "Renew as unseen" checkbox was also being ignored). Created attachment 169108 [details] [review] Bug 37332: Fix unseen and customer renewal date parameters in svc To test: 0. Enable unseen renewals i. Set the system preference UnseenRenewals to Allowed ii. Edit the circulation rules to specify the maximum number of unseen renewals allowed 1. Check out an item to a patron 2. In the checkouts table on that patron's account, check the "Renew" checkbox for that item 3. Select a custom renewal date using the Renewal due date flatpicker 4. Check the checkbox labeled "Renew as unseen if appropriate" 4. Click Renew selected items --> The item renews, but its new due date follows the renewal period specified in the circulation rules, regardless of what date was entered in the Renewal due date field --> The checkout still has all of its unseen renewals remaining, indicating that the renewal was not processed as an unseen renewal 5. Enter another custom renewal date and renew checkout with the Renew all button --> Same result 6. Apply patch and restart_all 7. Repeat test plan --> Custom renewal date is now respected --> Number of unseen renewals remaining decreases when "Renew as unseen" checkbox is checked 8. Renew the item with the "Renew as unseen" checkbox unchecked --> Confirm that number of unseen renewals is reset (i.e. the checkout once again has all of its unseen renewals remaining), indicating that the renewal was processed as a "seen" renewal Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org> Created attachment 169146 [details] [review] Bug 37332: Fix unseen and customer renewal date parameters in svc To test: 0. Enable unseen renewals i. Set the system preference UnseenRenewals to Allowed ii. Edit the circulation rules to specify the maximum number of unseen renewals allowed 1. Check out an item to a patron 2. In the checkouts table on that patron's account, check the "Renew" checkbox for that item 3. Select a custom renewal date using the Renewal due date flatpicker 4. Check the checkbox labeled "Renew as unseen if appropriate" 4. Click Renew selected items --> The item renews, but its new due date follows the renewal period specified in the circulation rules, regardless of what date was entered in the Renewal due date field --> The checkout still has all of its unseen renewals remaining, indicating that the renewal was not processed as an unseen renewal 5. Enter another custom renewal date and renew checkout with the Renew all button --> Same result 6. Apply patch and restart_all 7. Repeat test plan --> Custom renewal date is now respected --> Number of unseen renewals remaining decreases when "Renew as unseen" checkbox is checked 8. Renew the item with the "Renew as unseen" checkbox unchecked --> Confirm that number of unseen renewals is reset (i.e. the checkout once again has all of its unseen renewals remaining), indicating that the renewal was processed as a "seen" renewal Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.02 Depends on Bug 36084 not in 23.11.x I've had a go at a release note, but I'm not sure I have described it correctly. Please update to correct it. (In reply to David Nind from comment #14) > I've had a go at a release note, but I'm not sure I have described it > correctly. Please update to correct it. Thanks, David! In this case, one patch fixed two separate issues, which muddied the waters a bit. I clarified the release notes and updated the bug title to match. (In reply to Emily Lamancusa from comment #15) > (In reply to David Nind from comment #14) > > I've had a go at a release note, but I'm not sure I have described it > > correctly. Please update to correct it. > > Thanks, David! In this case, one patch fixed two separate issues, which > muddied the waters a bit. I clarified the release notes and updated the bug > title to match. Thanks Emily! Thanks Emily for the updates to release note! I removed "patch" from the release note. While developers use the term a lot, I think mere mortals don't use it all that much - even though they probably know what it means! I reported this bug too in comment #10 of bug 36393 and in bug 37189. Today I updated Koha to version 24.05.02 and I see here (https://koha-community.org/koha-24-05-02-released/) that the bug is supposed to be fixed. But when I try to renew an item with a custom renewal date, it still gets overridden by the hard due date in the circulation rules. In the system preferences, AllowRenewalLimitOverride is set to "Allow". (In reply to Isabel Pineda from comment #18) > I reported this bug too in comment #10 of bug 36393 and in bug 37189. Today > I updated Koha to version 24.05.02 and I see here > (https://koha-community.org/koha-24-05-02-released/) that the bug is > supposed to be fixed. But when I try to renew an item with a custom renewal > date, it still gets overridden by the hard due date in the circulation rules. > > In the system preferences, AllowRenewalLimitOverride is set to "Allow". Hi Isabel, that's not good. Could you please create a new bug report linking to this one with "depends"? We will need a new bug number for any follow-up as this was already in a released version. Thanks! (In reply to Katrin Fischer from comment #19) > (In reply to Isabel Pineda from comment #18) > > I reported this bug too in comment #10 of bug 36393 and in bug 37189. Today > > I updated Koha to version 24.05.02 and I see here > > (https://koha-community.org/koha-24-05-02-released/) that the bug is > > supposed to be fixed. But when I try to renew an item with a custom renewal > > date, it still gets overridden by the hard due date in the circulation rules. > > > > In the system preferences, AllowRenewalLimitOverride is set to "Allow". > > Hi Isabel, that's not good. Could you please create a new bug report linking > to this one with "depends"? We will need a new bug number for any follow-up > as this was already in a released version. Thanks! Sorry, just found bug 37189, so we can continue there. |