Bug 36393 - Renewal with a specific date does not take the new date due that we pick
Summary: Renewal with a specific date does not take the new date due that we pick
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Hammat wele
QA Contact: Kyle M Hall (khall)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-21 22:45 UTC by Hammat wele
Modified: 2024-07-16 14:37 UTC (History)
10 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06,23.05.12
Circulation function:


Attachments
Bug 36393: Renewal with a specific date does not take the new date due that we pick (2.10 KB, patch)
2024-03-21 22:55 UTC, Hammat wele
Details | Diff | Splinter Review
Bug 36393: Renewal with a specific date does not take the new date due that we pick (2.26 KB, patch)
2024-03-22 06:32 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 36393: Renewal with a specific date does not take the new date due that we pick (2.31 KB, patch)
2024-05-03 14:57 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Hammat wele 2024-03-21 22:45:33 UTC
To reproduce

1- Log in to the staff interface
     1-1. Make sure you have a ciculation rule that allows you to renew
     1-2. set the AllowRenewalLimitOverride system preference to Allow and SpecifyDueDate to Allow
2. Check out the item to a Borrower
5. Access the borrower's account and renew it until the limit is reached and note the due date.
6. Go to Circulation, click Renew
7. Enter the item barcode and choose a due date further than the due date from step 5 and submit
8. Click on Override limit and renew button
     ---> Note that the new date due is not the date that we picked in step 7
Comment 1 Hammat wele 2024-03-21 22:55:01 UTC
Created attachment 163654 [details] [review]
Bug 36393: Renewal with a specific date does not take the new date due that we pick

When we renew a notice with a specific date and we have to override the limit, the new date due is not the date that we picked

To reproduce

1- Log in to the staff interface
     1-1. Make sure you have a ciculation rule that allows you to renew
     1-2. set the AllowRenewalLimitOverride system preference to Allow and SpecifyDueDate to Allow
2. Check out the item to a Borrower
5. Access the borrower's account and renew it until the limit is reached and note the due date.
6. Go to Circulation, click Renew
7. Enter the item barcode and choose a due date further than the due date from step 5 and submit
8. Click on Override limit and renew button
     ---> Note that the new date due is not the date that we picked in step 7
9. Apply the patch
10. Repeat step 6, 7 snd 8
     ---> Note that the new date due is the date that we picked
Comment 2 PTFS Europe Sandboxes 2024-03-22 06:32:40 UTC
Created attachment 163658 [details] [review]
Bug 36393: Renewal with a specific date does not take the new date due that we pick

When we renew a notice with a specific date and we have to override the limit, the new date due is not the date that we picked

To reproduce

1- Log in to the staff interface
     1-1. Make sure you have a ciculation rule that allows you to renew
     1-2. set the AllowRenewalLimitOverride system preference to Allow and SpecifyDueDate to Allow
2. Check out the item to a Borrower
5. Access the borrower's account and renew it until the limit is reached and note the due date.
6. Go to Circulation, click Renew
7. Enter the item barcode and choose a due date further than the due date from step 5 and submit
8. Click on Override limit and renew button
     ---> Note that the new date due is not the date that we picked in step 7
9. Apply the patch
10. Repeat step 6, 7 snd 8
     ---> Note that the new date due is the date that we picked

Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi>
Comment 3 Kyle M Hall (khall) 2024-05-03 14:57:39 UTC
Created attachment 166146 [details] [review]
Bug 36393: Renewal with a specific date does not take the new date due that we pick

When we renew a notice with a specific date and we have to override the limit, the new date due is not the date that we picked

To reproduce

1- Log in to the staff interface
     1-1. Make sure you have a ciculation rule that allows you to renew
     1-2. set the AllowRenewalLimitOverride system preference to Allow and SpecifyDueDate to Allow
2. Check out the item to a Borrower
5. Access the borrower's account and renew it until the limit is reached and note the due date.
6. Go to Circulation, click Renew
7. Enter the item barcode and choose a due date further than the due date from step 5 and submit
8. Click on Override limit and renew button
     ---> Note that the new date due is not the date that we picked in step 7
9. Apply the patch
10. Repeat step 6, 7 snd 8
     ---> Note that the new date due is the date that we picked

Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Katrin Fischer 2024-05-03 16:08:34 UTC
Description reads like a bug, not an enh? ;)
Comment 5 Caroline Cyr La Rose 2024-05-03 17:45:11 UTC
(In reply to Katrin Fischer from comment #4)
> Description reads like a bug, not an enh? ;)

I think so too! Changing it.
Comment 6 Katrin Fischer 2024-05-03 17:48:15 UTC
Will be back for this on Monday!
Comment 7 Katrin Fischer 2024-05-06 07:13:11 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 8 Fridolin Somers 2024-05-24 13:23:45 UTC
Pushed to 23.11.x for 23.11.06
Comment 9 Lucas Gass (lukeg) 2024-05-28 21:36:00 UTC
Backported to 23.05.x for upcoming 23.05.12
Comment 10 Isabel Pineda 2024-06-20 14:01:31 UTC
I updated from 23.11 to 24.05 a few days ago, but now the renewal for a specific date is not working anymore. Although I give a specific date for a specific renewal, the system takes automatically the hard due date from the circulation rules. 

e.g.
In "Administration > Circulation rules" I save "15.08.2024" as hard due date for a specific item type and patron category.
Then I go to one patron of the above category to renew his borrowed items, and manually select "30.07.2024" as due date.
-> The system renews the items until 15.08.24. It ought to prioritize the manual due date for this specific patron.