Description
Lucas Gass (lukeg)
2024-07-16 13:34:46 UTC
So the Maskito mark works fine in dateaccessioned.pl plugin on additem.tt, so I think something in calendar.inc may be causing the problem. I am updating severity as this is also an accessibility issue. The direct input is much easier than using the calendar widget for some. Could you catch me and demo what you're seeing Lucas? I just tried and I can't get the date to malform but maybe I'm not seeing what you are. Created attachment 169083 [details] [review] Bug 37371: Move Maskito instantiation to onReady Created attachment 169085 [details] [review] Bug 37371: Set overwrite mode to replace In our case I think overwriteMode needs to be set to replace: https://maskito.dev/core-concepts/overwrite-mode Created attachment 169086 [details] [review] Bug 37371: Move Maskito init to onReady in dateaccessioned.pl Created attachment 169087 [details] [review] Bug 37371: Move Maskito init to onReady in dateaccessioned.pl Created attachment 169088 [details] [review] Bug 37371: Move Maskito instantiation to onReady ( OPAC ) To test: 1. Find a any date picker in Koha, like DOB in the patron record. 2. Add a date, either manually or using the date picker. 3. Once there is a date like 07/15/2024 try to edit only part of the date, or the '15'. 4. The date easily becomes malformed. 5. APPLY PATCHSET, maybe clear your browser cache too 6. Try directly inputing dates. I would suggest the following places: -Patron record DOB -Specify due date on circ/circulation.pl as this includes time -Add item screen, this is the dateaccessioned plugin -OPAC self reg/self modify Thank you Martin for figuring this one out! Created attachment 169094 [details] [review] Bug 37371: Move Maskito instantiation to onReady ( OPAC ) To test: 1. Find a any date picker in Koha, like DOB in the patron record. 2. Add a date, either manually or using the date picker. 3. Once there is a date like 07/15/2024 try to edit only part of the date, or the '15'. 4. The date easily becomes malformed. 5. APPLY PATCHSET, maybe clear your browser cache too 6. Try directly inputing dates. I would suggest the following places: -Patron record DOB -Specify due date on circ/circulation.pl as this includes time -Add item screen, this is the dateaccessioned plugin -OPAC self reg/self modify Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 169135 [details] [review] Bug 37371: Move Maskito instantiation to onReady Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 169136 [details] [review] Bug 37371: Set overwrite mode to replace In our case I think overwriteMode needs to be set to replace: https://maskito.dev/core-concepts/overwrite-mode Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 169137 [details] [review] Bug 37371: Move Maskito init to onReady in dateaccessioned.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 169138 [details] [review] Bug 37371: Move Maskito instantiation to onReady ( OPAC ) To test: 1. Find a any date picker in Koha, like DOB in the patron record. 2. Add a date, either manually or using the date picker. 3. Once there is a date like 07/15/2024 try to edit only part of the date, or the '15'. 4. The date easily becomes malformed. 5. APPLY PATCHSET, maybe clear your browser cache too 6. Try directly inputing dates. I would suggest the following places: -Patron record DOB -Specify due date on circ/circulation.pl as this includes time -Add item screen, this is the dateaccessioned plugin -OPAC self reg/self modify Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 169151 [details] [review] Bug 37371: Move Maskito instantiation to onReady Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 169152 [details] [review] Bug 37371: Set overwrite mode to replace In our case I think overwriteMode needs to be set to replace: https://maskito.dev/core-concepts/overwrite-mode Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 169153 [details] [review] Bug 37371: Move Maskito init to onReady in dateaccessioned.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 169154 [details] [review] Bug 37371: Move Maskito instantiation to onReady ( OPAC ) To test: 1. Find a any date picker in Koha, like DOB in the patron record. 2. Add a date, either manually or using the date picker. 3. Once there is a date like 07/15/2024 try to edit only part of the date, or the '15'. 4. The date easily becomes malformed. 5. APPLY PATCHSET, maybe clear your browser cache too 6. Try directly inputing dates. I would suggest the following places: -Patron record DOB -Specify due date on circ/circulation.pl as this includes time -Add item screen, this is the dateaccessioned plugin -OPAC self reg/self modify Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant Backported to 24.05.x for upcoming 24.05.04 Depends on Bug 33703 not in 23.11.x This looks like a bug fix, nothing to change/edit in the manual. Please reopen with more details if needed. |