| Summary: | Searching for an empty string for clubs in an item's hold tab is not allowed | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Sam Lau <samalau> |
| Component: | Hold requests | Assignee: | Sam Lau <samalau> |
| Status: | Pushed to main --- | QA Contact: | Lucas Gass (lukeg) <lucas> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | gmcharlt, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
25.05.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 37427: Fix club search to display all clubs when search field is empty, consistent with patron search behavior
Bug 37427: Fix club search to display all clubs when search field is empty, consistent with patron search behavior Bug 37427: Fix club search to display all clubs when search field is empty, consistent with patron search behavior |
||
|
Description
Sam Lau
2024-07-22 19:58:56 UTC
Created attachment 169382 [details] [review] Bug 37427: Fix club search to display all clubs when search field is empty, consistent with patron search behavior To test: 1) Create multiple patron clubs 2) Find a bib 3) Click Holds, then Clubs 4) Without entering any text, press the search button 5) Note that the list of clubs is not shown. 6) Apply patch and restart_all 7) Press the search button again, the entire list of clubs should be shown. 8) Ensure original search functionality still works Created attachment 169385 [details] [review] Bug 37427: Fix club search to display all clubs when search field is empty, consistent with patron search behavior To test: 1) Create multiple patron clubs 2) Find a bib 3) Click Holds, then Clubs 4) Without entering any text, press the search button 5) Note that the list of clubs is not shown. 6) Apply patch and restart_all 7) Press the search button again, the entire list of clubs should be shown. 8) Ensure original search functionality still works Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 174945 [details] [review] Bug 37427: Fix club search to display all clubs when search field is empty, consistent with patron search behavior To test: 1) Create multiple patron clubs 2) Find a bib 3) Click Holds, then Clubs 4) Without entering any text, press the search button 5) Note that the list of clubs is not shown. 6) Apply patch and restart_all 7) Press the search button again, the entire list of clubs should be shown. 8) Ensure original search functionality still works Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Pushed for 25.05! Well done everyone, thank you! |