Summary: | Searching for an empty string for clubs in an item's hold tab is not allowed | ||
---|---|---|---|
Product: | Koha | Reporter: | Sam Lau <samalau> |
Component: | Hold requests | Assignee: | Sam Lau <samalau> |
Status: | Pushed to stable --- | QA Contact: | Lucas Gass (lukeg) <lucas> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | david, gmcharlt, lucas, wainuiwitikapark |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This improves searching for patron clubs on a record's holds page - it now works similar to the patron search tab. You can now click search with no text in the search box, and a list of clubs are displayed. Previously, you had to enter the club ID or partial name to get a result.
|
|
Version(s) released in: |
25.05.00,24.11.02
|
Circulation function: | |
Attachments: |
Bug 37427: Fix club search to display all clubs when search field is empty, consistent with patron search behavior
Bug 37427: Fix club search to display all clubs when search field is empty, consistent with patron search behavior Bug 37427: Fix club search to display all clubs when search field is empty, consistent with patron search behavior |
Description
Sam Lau
2024-07-22 19:58:56 UTC
Created attachment 169382 [details] [review] Bug 37427: Fix club search to display all clubs when search field is empty, consistent with patron search behavior To test: 1) Create multiple patron clubs 2) Find a bib 3) Click Holds, then Clubs 4) Without entering any text, press the search button 5) Note that the list of clubs is not shown. 6) Apply patch and restart_all 7) Press the search button again, the entire list of clubs should be shown. 8) Ensure original search functionality still works Created attachment 169385 [details] [review] Bug 37427: Fix club search to display all clubs when search field is empty, consistent with patron search behavior To test: 1) Create multiple patron clubs 2) Find a bib 3) Click Holds, then Clubs 4) Without entering any text, press the search button 5) Note that the list of clubs is not shown. 6) Apply patch and restart_all 7) Press the search button again, the entire list of clubs should be shown. 8) Ensure original search functionality still works Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 174945 [details] [review] Bug 37427: Fix club search to display all clubs when search field is empty, consistent with patron search behavior To test: 1) Create multiple patron clubs 2) Find a bib 3) Click Holds, then Clubs 4) Without entering any text, press the search button 5) Note that the list of clubs is not shown. 6) Apply patch and restart_all 7) Press the search button again, the entire list of clubs should be shown. 8) Ensure original search functionality still works Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Pushed for 25.05! Well done everyone, thank you! This is in the commit log for 24.11, though not noted here yet. Not backporting to 24.05.x unless requested Pushed to 24.11.02 |