Bug 37427 - Searching for an empty string for clubs in an item's hold tab is not allowed
Summary: Searching for an empty string for clubs in an item's hold tab is not allowed
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Sam Lau
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-22 19:58 UTC by Sam Lau
Modified: 2024-07-22 20:34 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 37427: Fix club search to display all clubs when search field is empty, consistent with patron search behavior (3.64 KB, patch)
2024-07-22 20:09 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 37427: Fix club search to display all clubs when search field is empty, consistent with patron search behavior (3.69 KB, patch)
2024-07-22 20:34 UTC, Roman Dolny
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Lau 2024-07-22 19:58:56 UTC
To reproduce: 
1) have some patron clubs
2) find a bib
3) Click Holds, then Clubs
4) Without entering any text, press the search button
5) Note that the list of clubs is not shown.

However, when searching for a patron with an empty string, it returns the entire list of patrons. I think it would be useful if club searching followed this same functionality.
Comment 1 Sam Lau 2024-07-22 20:09:50 UTC
Created attachment 169382 [details] [review]
Bug 37427: Fix club search to display all clubs when search field is empty, consistent with patron search behavior

To test:
1) Create multiple patron clubs
2) Find a bib
3) Click Holds, then Clubs
4) Without entering any text, press the search button
5) Note that the list of clubs is not shown.
6) Apply patch and restart_all
7) Press the search button again, the entire list of clubs should be shown.
8) Ensure original search functionality still works
Comment 2 Roman Dolny 2024-07-22 20:34:04 UTC
Created attachment 169385 [details] [review]
Bug 37427: Fix club search to display all clubs when search field is empty, consistent with patron search behavior

To test:
1) Create multiple patron clubs
2) Find a bib
3) Click Holds, then Clubs
4) Without entering any text, press the search button
5) Note that the list of clubs is not shown.
6) Apply patch and restart_all
7) Press the search button again, the entire list of clubs should be shown.
8) Ensure original search functionality still works

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>