To reproduce: 1) have some patron clubs 2) find a bib 3) Click Holds, then Clubs 4) Without entering any text, press the search button 5) Note that the list of clubs is not shown. However, when searching for a patron with an empty string, it returns the entire list of patrons. I think it would be useful if club searching followed this same functionality.
Created attachment 169382 [details] [review] Bug 37427: Fix club search to display all clubs when search field is empty, consistent with patron search behavior To test: 1) Create multiple patron clubs 2) Find a bib 3) Click Holds, then Clubs 4) Without entering any text, press the search button 5) Note that the list of clubs is not shown. 6) Apply patch and restart_all 7) Press the search button again, the entire list of clubs should be shown. 8) Ensure original search functionality still works
Created attachment 169385 [details] [review] Bug 37427: Fix club search to display all clubs when search field is empty, consistent with patron search behavior To test: 1) Create multiple patron clubs 2) Find a bib 3) Click Holds, then Clubs 4) Without entering any text, press the search button 5) Note that the list of clubs is not shown. 6) Apply patch and restart_all 7) Press the search button again, the entire list of clubs should be shown. 8) Ensure original search functionality still works Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Created attachment 174945 [details] [review] Bug 37427: Fix club search to display all clubs when search field is empty, consistent with patron search behavior To test: 1) Create multiple patron clubs 2) Find a bib 3) Click Holds, then Clubs 4) Without entering any text, press the search button 5) Note that the list of clubs is not shown. 6) Apply patch and restart_all 7) Press the search button again, the entire list of clubs should be shown. 8) Ensure original search functionality still works Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Pushed for 25.05! Well done everyone, thank you!