Bug 37436

Summary:	Move EmailPatronWhenHoldIsPlaced to holds policy system preferences
Product:	Koha	Reporter:	Caroline Cyr La Rose <caroline.cyr-la-rose>
Component:	System Administration	Assignee:	Caroline Cyr La Rose <caroline.cyr-la-rose>
Status:	RESOLVED FIXED	QA Contact:	Katrin Fischer <katrin.fischer>
Severity:	enhancement
Priority:	P5 - low	CC:	gmcharlt, hebah, lucas
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:	This patch moves the EmailPatronWhenHoldIsPlaced system preference from Circulation > Patron restrictions to Circulation > Holds policy.	Version(s) released in:	24.11.00
Circulation function:
Bug Depends on:	17617
Bug Blocks:
Attachments:	Bug 37436: Move EmailPatronWhenHoldIsPlaced to Holds policy sysprefs Bug 37436: Move EmailPatronWhenHoldIsPlaced to Holds policy sysprefs

Description Caroline Cyr La Rose 2024-07-23 16:03:40 UTC

The new EmailPatronWhenHoldIsPlaced system preference is in Circulation > Patron restrictions. However, it has nothing to do with patron restrictions.

I propose to move it to Circulation > Holds policy since it has to do with holds.

Another option could be Patrons > Notices and notifications since it has to do with sending a notice to the patron.

Comment 1 Caroline Cyr La Rose 2024-07-23 16:09:43 UTC

Created attachment 169437 [details] [review]
Bug 37436: Move EmailPatronWhenHoldIsPlaced to Holds policy sysprefs

This patch moves the EmailPatronWhenHoldIsPlaced system preference
from Circulation > Patron restrictions to Circulation > Holds policy.

To test:
1. Apply patch
2. Go to Administration > System preferences > Circulation > Holds
   policy
   --> EmailPatronWhenHoldIsPlaced should be right after
       emailLibrarianWhenHoldIsPlaced

Comment 2 ByWater Sandboxes 2024-07-24 14:14:00 UTC

Created attachment 169493 [details] [review]
Bug 37436: Move EmailPatronWhenHoldIsPlaced to Holds policy sysprefs

This patch moves the EmailPatronWhenHoldIsPlaced system preference
from Circulation > Patron restrictions to Circulation > Holds policy.

To test:
1. Apply patch
2. Go to Administration > System preferences > Circulation > Holds
   policy
   --> EmailPatronWhenHoldIsPlaced should be right after
       emailLibrarianWhenHoldIsPlaced

Signed-off-by: hebah <hebah@bywatersolutions.com>

Comment 3 hebah 2024-07-24 14:15:39 UTC

Much more logical place for it, works as expected.

Comment 4 Katrin Fischer 2024-09-02 09:31:48 UTC

QA'd by RM. Thanks Caroline!

Comment 5 Katrin Fischer 2024-09-02 10:21:29 UTC

Pushed for 24.11!

Well done everyone, thank you!