Summary: | ChildNeedsGuarantor description misleading | ||
---|---|---|---|
Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Component: | System Administration | Assignee: | Kyle M Hall (khall) <kyle> |
Status: | Pushed to stable --- | QA Contact: | Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | baptiste.wojtkowski, gmcharlt, kyle, lucas, magnus |
Version: | Main | Keywords: | release-notes-needed |
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36059 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 |
||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | String patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.11.00,25.05.01
|
Circulation function: | |
Bug Depends on: | 12133 | ||
Bug Blocks: | |||
Attachments: |
Bug 37439: Fix misleading ChildNeedsGuarantor description
Bug 37439: Fix misleading ChildNeedsGuarantor description Bug 37439: Fix misleading ChildNeedsGuarantor description |
Description
Caroline Cyr La Rose
2024-07-23 19:37:50 UTC
Created attachment 182492 [details] [review] Bug 37439: Fix misleading ChildNeedsGuarantor description Unless I misunderstood the purpose of the ChildNeedsGuarantor system preference, I think the description is misleading. Created attachment 182509 [details] [review] Bug 37439: Fix misleading ChildNeedsGuarantor description Unless I misunderstood the purpose of the ChildNeedsGuarantor system preference, I think the description is misleading. Signed-off-by: Magnus Enger <magnus@libriotech.no> Applied the patch, reloaded the syspref page for ChildNeedsGuarantor, verified the new description looks OK. After signing off I started wondering if the name of the syspref itself makes sense, but changing it might be too much work for very litle gain? (In reply to Magnus Enger from comment #3) > After signing off I started wondering if the name of the syspref itself > makes sense, but changing it might be too much work for very litle gain? I agree that the name is also misleading, but thought it would be too much work to change it everywhere and the bug wouldn't get any attention. But if someone is willing to change the name also, I would be for it. In my opinion, the problem is the syspref itself, which makes sense only on an historical basis. There simply should be a flag like "can be guarantee" at the scale of the user, don't you think ? This however makes things more clear, setting to PQA. Created attachment 183395 [details] [review] Bug 37439: Fix misleading ChildNeedsGuarantor description Unless I misunderstood the purpose of the ChildNeedsGuarantor system preference, I think the description is misleading. Signed-off-by: Magnus Enger <magnus@libriotech.no> Applied the patch, reloaded the syspref page for ChildNeedsGuarantor, verified the new description looks OK. Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> Nice work everyone! Pushed to main for 25.11 Nice work everyone! Pushed to 25.05.x for 25.05.03 |