Unless I misunderstood the purpose of the ChildNeedsGuarantor system preference, I think the description is misleading. It currently states A child patron [doesn't need/must have] a guarantor when adding the patron. However, this is not limited to children. It affect patrons whose patron category is set to 'can be guarantee'. I'm not sure what the best formulation would be. Maybe something like When a patron category is set to 'can be guarantee', the guarantor is [mandatory / not mandatory].
Created attachment 182492 [details] [review] Bug 37439: Fix misleading ChildNeedsGuarantor description Unless I misunderstood the purpose of the ChildNeedsGuarantor system preference, I think the description is misleading.
Created attachment 182509 [details] [review] Bug 37439: Fix misleading ChildNeedsGuarantor description Unless I misunderstood the purpose of the ChildNeedsGuarantor system preference, I think the description is misleading. Signed-off-by: Magnus Enger <magnus@libriotech.no> Applied the patch, reloaded the syspref page for ChildNeedsGuarantor, verified the new description looks OK.
After signing off I started wondering if the name of the syspref itself makes sense, but changing it might be too much work for very litle gain?