Bug 37439 - ChildNeedsGuarantor description misleading
Summary: ChildNeedsGuarantor description misleading
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Kyle M Hall (khall)
QA Contact: Baptiste Wojtkowski (bwoj)
URL:
Keywords: release-notes-needed
Depends on: 12133
Blocks:
  Show dependency treegraph
 
Reported: 2024-07-23 19:37 UTC by Caroline Cyr La Rose
Modified: 2025-06-24 09:31 UTC (History)
5 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.01
Circulation function:


Attachments
Bug 37439: Fix misleading ChildNeedsGuarantor description (1.66 KB, patch)
2025-05-15 16:42 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 37439: Fix misleading ChildNeedsGuarantor description (1.80 KB, patch)
2025-05-16 07:09 UTC, Magnus Enger
Details | Diff | Splinter Review
Bug 37439: Fix misleading ChildNeedsGuarantor description (1.86 KB, patch)
2025-06-20 13:23 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2024-07-23 19:37:50 UTC
Unless I misunderstood the purpose of the ChildNeedsGuarantor system preference, I  think the description is misleading.

It currently states

A child patron [doesn't need/must have] a guarantor when adding the patron.

However, this is not limited to children.  It affect patrons whose patron category is set to 'can be guarantee'. 

I'm not sure what the best formulation would be.

Maybe something like

When a patron category is set to 'can be guarantee', the guarantor is [mandatory / not mandatory].
Comment 1 Kyle M Hall (khall) 2025-05-15 16:42:10 UTC Comment hidden (obsolete)
Comment 2 Magnus Enger 2025-05-16 07:09:19 UTC
Created attachment 182509 [details] [review]
Bug 37439: Fix misleading ChildNeedsGuarantor description

Unless I misunderstood the purpose of the ChildNeedsGuarantor system preference, I  think the description is misleading.

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Applied the patch, reloaded the syspref page for ChildNeedsGuarantor,
verified the new description looks OK.
Comment 3 Magnus Enger 2025-05-16 07:11:26 UTC
After signing off I started wondering if the name of the syspref itself makes sense, but changing it might be too much work for very litle gain?
Comment 4 Caroline Cyr La Rose 2025-05-28 15:21:04 UTC
(In reply to Magnus Enger from comment #3)
> After signing off I started wondering if the name of the syspref itself
> makes sense, but changing it might be too much work for very litle gain?

I agree that the name is also misleading, but thought it would be too much work to change it everywhere and the bug wouldn't get any attention. But if someone is willing to change the name also, I would be for it.
Comment 5 Baptiste Wojtkowski (bwoj) 2025-06-20 13:19:28 UTC
In my opinion, the problem is the syspref itself, which makes sense only on an historical basis. There simply should be a flag like "can be guarantee" at the scale of the user, don't you think ?
Comment 6 Baptiste Wojtkowski (bwoj) 2025-06-20 13:22:24 UTC
This however makes things more clear, setting to PQA.
Comment 7 Baptiste Wojtkowski (bwoj) 2025-06-20 13:23:31 UTC
Created attachment 183395 [details] [review]
Bug 37439: Fix misleading ChildNeedsGuarantor description

Unless I misunderstood the purpose of the ChildNeedsGuarantor system preference, I  think the description is misleading.

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Applied the patch, reloaded the syspref page for ChildNeedsGuarantor,
verified the new description looks OK.
Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>
Comment 8 Lucas Gass (lukeg) 2025-06-23 15:52:19 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 9 Paul Derscheid 2025-06-24 09:31:04 UTC
Nice work everyone!

Pushed to 25.05.x for 25.05.03