Bug 37451

Summary: Restrictions due to discharge should not be able to be removed
Product: Koha Reporter: Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski>
Component: PatronsAssignee: Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski>
Status: Signed Off --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt, kyle.m.hall, phil, shi-yao.wang
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 37451 - Remove the ability to delete a restriction due to discharge
Bug 37451 - Remove the ability to delete a restriction due to discharge

Description Baptiste Wojtkowski (bwoj) 2024-07-24 13:51:08 UTC
However it is not possible to remove the discharge, it is possible to remove the suspension associated to the discharge. This can lead to a lot of undesired behaviors when the user asks for another discharge or get suspended for another reason.

Suspension due to discharge should therefore be definitive.
Comment 1 Baptiste Wojtkowski (bwoj) 2024-07-24 13:57:19 UTC
Created attachment 169491 [details] [review]
Bug 37451 - Remove the ability to delete a restriction due to discharge

However it is not possible to remove the discharge, it is possible to remove the suspension associated to the discharge. This can lead to a lot of undesired behaviors when the user asks for another discharge or get suspended for another reason.

Suspension due to discharge should therefore be definitive.

TEST PLAN:
1 - Go to patron -> pick a patron -> go to discharges
2 - Generate a discharge for the patron
3 - Go to check out -> restrictions
4 - There should be a restriction with type discharge that can be
  deleted
5 - Apply patch
6 - There still should be a restriction but the button has been replaced
  by an infobox
Comment 2 Shi Yao Wang 2024-09-26 19:01:05 UTC
Created attachment 172020 [details] [review]
Bug 37451 - Remove the ability to delete a restriction due to discharge

However it is not possible to remove the discharge, it is possible to remove the suspension associated to the discharge. This can lead to a lot of undesired behaviors when the user asks for another discharge or get suspended for another reason.

Suspension due to discharge should therefore be definitive.

TEST PLAN:
1 - Go to patron -> pick a patron -> go to discharges
2 - Generate a discharge for the patron
3 - Go to check out -> restrictions
4 - There should be a restriction with type discharge that can be
  deleted
5 - Apply patch
6 - There still should be a restriction but the button has been replaced
  by an infobox

Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com>