However it is not possible to remove the discharge, it is possible to remove the suspension associated to the discharge. This can lead to a lot of undesired behaviors when the user asks for another discharge or get suspended for another reason. Suspension due to discharge should therefore be definitive.
Created attachment 169491 [details] [review] Bug 37451 - Remove the ability to delete a restriction due to discharge However it is not possible to remove the discharge, it is possible to remove the suspension associated to the discharge. This can lead to a lot of undesired behaviors when the user asks for another discharge or get suspended for another reason. Suspension due to discharge should therefore be definitive. TEST PLAN: 1 - Go to patron -> pick a patron -> go to discharges 2 - Generate a discharge for the patron 3 - Go to check out -> restrictions 4 - There should be a restriction with type discharge that can be deleted 5 - Apply patch 6 - There still should be a restriction but the button has been replaced by an infobox
Created attachment 172020 [details] [review] Bug 37451 - Remove the ability to delete a restriction due to discharge However it is not possible to remove the discharge, it is possible to remove the suspension associated to the discharge. This can lead to a lot of undesired behaviors when the user asks for another discharge or get suspended for another reason. Suspension due to discharge should therefore be definitive. TEST PLAN: 1 - Go to patron -> pick a patron -> go to discharges 2 - Generate a discharge for the patron 3 - Go to check out -> restrictions 4 - There should be a restriction with type discharge that can be deleted 5 - Apply patch 6 - There still should be a restriction but the button has been replaced by an infobox Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com>