Bug 37461

Summary: Typo in SMSSendAdditionalOptions description
Product: Koha Reporter: Caroline Cyr La Rose <caroline.cyr-la-rose>
Component: System AdministrationAssignee: Caroline Cyr La Rose <caroline.cyr-la-rose>
Status: RESOLVED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: trivial    
Priority: P5 - low CC: barbara.johnson, david, fridolin.somers, gmcharlt, lucas, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: String patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.04
Circulation function:
Bug Depends on: 36051    
Bug Blocks:    
Attachments: Bug 37461: Typo in SMSSendAdditionalOptions description
Bug 37461: Typo in SMSSendAdditionalOptions description
Bug 37461: Typo in SMSSendAdditionalOptions description
Bug 37461: Typo in SMSSendAdditionalOptions description
Bug 37461: Typo in SMSSendAdditionalOptions description

Description Caroline Cyr La Rose 2024-07-24 19:13:55 UTC
The SMSSendAdditionalOptions syspref description currently reads

If the SMS::Send driver requires more options that just username/login and password, entire them here as YAML key/value pairs:

It should be "enter them here".
Comment 1 Caroline Cyr La Rose 2024-07-24 19:14:29 UTC
I also wonder if it should be it's own syspref rather than one of four in the same sentence?
Comment 2 Caroline Cyr La Rose 2024-07-24 19:18:50 UTC
Created attachment 169514 [details] [review]
Bug 37461: Typo in SMSSendAdditionalOptions description

This patch correct a typo in the SMSSendAdditionalOptions system
preference description.

To test:
1. Apply patch
2. Go to Administration > System preferences
3. Search for SMSSendAdditionalOptions
4. Read the description, make sure there are no spelling or grammar
   error
Comment 3 Barbara Johnson 2024-07-25 16:03:50 UTC
After applying the patch in a sandbox I am seeing no change. 

There are no quotes around the words "enter them here".

Also there is a typo in the sentence - it reads as follows:

If the SMS::Send driver requires more options that just username/login and password:

The word 'that' should be 'than' so that it reads 'more options than'

Like this:
If the SMS::Send driver requires more options than just username/login and password:
Comment 4 Caroline Cyr La Rose 2024-07-25 16:16:06 UTC
Created attachment 169592 [details] [review]
Bug 37461: Typo in SMSSendAdditionalOptions description
Comment 5 Caroline Cyr La Rose 2024-07-25 16:17:26 UTC
Created attachment 169593 [details] [review]
Bug 37461: Typo in SMSSendAdditionalOptions description

This patch correct a typo in the SMSSendAdditionalOptions system
preference description.

To test:
1. Apply patch
2. Go to Administration > System preferences
3. Search for SMSSendAdditionalOptions
4. Read the description, make sure there are no spelling or grammar
   error
Comment 6 Caroline Cyr La Rose 2024-07-25 16:19:11 UTC
Hi Barbara, 

Thanks for testing. I hadn't seen the other typo (that -> than).

As for the "enter them here", I didn't mean that the words should be between quotes but that "entire" should be "enter".

I corrected both in the new patch and set back to Needs Signoff.

Caroline
Comment 7 Laura Escamilla 2024-07-25 16:25:03 UTC
Created attachment 169595 [details] [review]
Bug 37461: Typo in SMSSendAdditionalOptions description

This patch correct a typo in the SMSSendAdditionalOptions system
preference description.

To test:
1. Apply patch
2. Go to Administration > System preferences
3. Search for SMSSendAdditionalOptions
4. Read the description, make sure there are no spelling or grammar
   error

Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Comment 8 Marcel de Rooy 2024-08-02 09:09:03 UTC
Created attachment 169993 [details] [review]
Bug 37461: Typo in SMSSendAdditionalOptions description

This patch correct a typo in the SMSSendAdditionalOptions system
preference description.

To test:
1. Apply patch
2. Go to Administration > System preferences
3. Search for SMSSendAdditionalOptions
4. Read the description, make sure there are no spelling or grammar
   error

Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 9 Katrin Fischer 2024-08-02 17:01:40 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 10 Lucas Gass (lukeg) 2024-09-11 16:03:49 UTC
Backported to 24.05.x for upcoming 24.05.04
Comment 11 Fridolin Somers 2024-09-25 08:38:28 UTC
Depends on Bug 36051 not in 23.11.x
Comment 12 Caroline Cyr La Rose 2024-10-09 18:34:15 UTC
I think I had already entered it in the manual with the corrections. Nothing to change.