The SMSSendAdditionalOptions syspref description currently reads If the SMS::Send driver requires more options that just username/login and password, entire them here as YAML key/value pairs: It should be "enter them here".
I also wonder if it should be it's own syspref rather than one of four in the same sentence?
Created attachment 169514 [details] [review] Bug 37461: Typo in SMSSendAdditionalOptions description This patch correct a typo in the SMSSendAdditionalOptions system preference description. To test: 1. Apply patch 2. Go to Administration > System preferences 3. Search for SMSSendAdditionalOptions 4. Read the description, make sure there are no spelling or grammar error
After applying the patch in a sandbox I am seeing no change. There are no quotes around the words "enter them here". Also there is a typo in the sentence - it reads as follows: If the SMS::Send driver requires more options that just username/login and password: The word 'that' should be 'than' so that it reads 'more options than' Like this: If the SMS::Send driver requires more options than just username/login and password:
Created attachment 169592 [details] [review] Bug 37461: Typo in SMSSendAdditionalOptions description
Created attachment 169593 [details] [review] Bug 37461: Typo in SMSSendAdditionalOptions description This patch correct a typo in the SMSSendAdditionalOptions system preference description. To test: 1. Apply patch 2. Go to Administration > System preferences 3. Search for SMSSendAdditionalOptions 4. Read the description, make sure there are no spelling or grammar error
Hi Barbara, Thanks for testing. I hadn't seen the other typo (that -> than). As for the "enter them here", I didn't mean that the words should be between quotes but that "entire" should be "enter". I corrected both in the new patch and set back to Needs Signoff. Caroline
Created attachment 169595 [details] [review] Bug 37461: Typo in SMSSendAdditionalOptions description This patch correct a typo in the SMSSendAdditionalOptions system preference description. To test: 1. Apply patch 2. Go to Administration > System preferences 3. Search for SMSSendAdditionalOptions 4. Read the description, make sure there are no spelling or grammar error Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Created attachment 169993 [details] [review] Bug 37461: Typo in SMSSendAdditionalOptions description This patch correct a typo in the SMSSendAdditionalOptions system preference description. To test: 1. Apply patch 2. Go to Administration > System preferences 3. Search for SMSSendAdditionalOptions 4. Read the description, make sure there are no spelling or grammar error Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.04
Depends on Bug 36051 not in 23.11.x
I think I had already entered it in the manual with the corrections. Nothing to change.