Summary: | Remove duplicate asset import from KBART template | ||
---|---|---|---|
Product: | Koha | Reporter: | Matt Blenkinsop <matt.blenkinsop> |
Component: | ERM | Assignee: | Matt Blenkinsop <matt.blenkinsop> |
Status: | RESOLVED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, jonathan.field, lucas, martin.renvoize, matt.blenkinsop, pedro.amorim |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
24.11.00,24.05.06
|
Circulation function: | |
Bug Depends on: | 34788 | ||
Bug Blocks: | |||
Attachments: |
Bug 37491: Remove duplicate asset import
Bug 37491: Remove duplicate asset import Bug 37491: Remove duplicate asset import |
Description
Matt Blenkinsop
2024-07-26 11:11:46 UTC
Created attachment 169691 [details] [review] Bug 37491: Remove duplicate asset import This patch removes a duplicated asset import from import_from_kbart_file.inc Test plan: 1) Look at the commit diff and observe that where previously there were two uses of "[% Asset.js("js/job_progress.js") | $raw %]" and now there is just one Created attachment 169692 [details] [review] Bug 37491: Remove duplicate asset import This patch removes a duplicated asset import from import_from_kbart_file.inc Test plan: 1) Apply patch and look at import_from_kbart_file.inc to observe that where previously there were two uses of "[% Asset.js("js/job_progress.js") | $raw %]" and now there is just one Created attachment 169781 [details] [review] Bug 37491: Remove duplicate asset import This patch removes a duplicated asset import from import_from_kbart_file.inc Test plan: 1) Apply patch and look at import_from_kbart_file.inc to observe that where previously there were two uses of "[% Asset.js("js/job_progress.js") | $raw %]" and now there is just one Signed-off-by: Sam Lau <samalau@gmail.com> QA'd by RM. Pushed for 24.11! Well done everyone, thank you! Skipping for release notes as this is quite technical and kind of self-explanatory to developers. Also here right ? koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/erm_sushi_harvester.inc This was pushed for 24.05.x for upcoming 24.05.06 but I neglected to update the report. Sorry all. |