Bug 37491 - Remove duplicate asset import from KBART template
Summary: Remove duplicate asset import from KBART template
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Matt Blenkinsop
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-26 11:11 UTC by Matt Blenkinsop
Modified: 2024-09-02 10:21 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 37491: Remove duplicate asset import (1.18 KB, patch)
2024-07-26 11:14 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 37491: Remove duplicate asset import (1.20 KB, patch)
2024-07-26 11:15 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 37491: Remove duplicate asset import (1.23 KB, patch)
2024-07-26 19:50 UTC, Sam Lau
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Blenkinsop 2024-07-26 11:11:46 UTC

    
Comment 1 Matt Blenkinsop 2024-07-26 11:14:03 UTC
Created attachment 169691 [details] [review]
Bug 37491: Remove duplicate asset import

This patch removes a duplicated asset import from import_from_kbart_file.inc

Test plan:
1) Look at the commit diff and observe that where previously there were two uses of "[% Asset.js("js/job_progress.js") | $raw %]" and now there is just one
Comment 2 Matt Blenkinsop 2024-07-26 11:15:37 UTC
Created attachment 169692 [details] [review]
Bug 37491: Remove duplicate asset import

This patch removes a duplicated asset import from import_from_kbart_file.inc

Test plan:
1) Apply patch and look at import_from_kbart_file.inc to observe that where previously there were two uses of "[% Asset.js("js/job_progress.js") | $raw %]" and now there is just one
Comment 3 Sam Lau 2024-07-26 19:50:00 UTC
Created attachment 169781 [details] [review]
Bug 37491: Remove duplicate asset import

This patch removes a duplicated asset import from import_from_kbart_file.inc

Test plan:
1) Apply patch and look at import_from_kbart_file.inc to observe that where previously there were two uses of "[% Asset.js("js/job_progress.js") | $raw %]" and now there is just one

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 4 Katrin Fischer 2024-09-02 09:33:14 UTC
QA'd by RM.
Comment 5 Katrin Fischer 2024-09-02 10:21:35 UTC
Pushed for 24.11!

Well done everyone, thank you!