| Summary: | Pressing "Renew all" redirects user to "Export data" tool if one of the items is not renewable | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Emmi Takkinen <emmi.takkinen> |
| Component: | Circulation | Assignee: | Emmi Takkinen <emmi.takkinen> |
| Status: | Pushed to stable --- | QA Contact: | Paul Derscheid <paul.derscheid> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | gmcharlt, kyle.m.hall, lucas, paul.derscheid |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.11.00,24.05.06
|
|
| Circulation function: | holds | ||
| Attachments: |
Bug 37524: Do not attempt to renew check outs if there is nothing to renew
Bug 37524: Do not attempt to renew check outs if there is nothing to renew Bug 37524: Do not attempt to renew check outs if there is nothing to renew Bug 37524: (QA follow-up) Tidy affected block in checkouts.js |
||
|
Description
Emmi Takkinen
2024-07-30 11:51:19 UTC
Changing this as minor bug. There is something wrong with call to renew_all function, I'm seeing following error in browsers console.
>Uncaught TypeError: renew_all(...) is undefined
which points to this part in checkouts.js
renew_all(item_ids, renew).then(() => {
// Refocus on barcode field if it exists
if ( $("#barcode").length ) {
$("#barcode").focus();
}
if ( refresh_table ) {
RefreshIssuesTable();
}
$('#RenewChecked, #CheckinChecked').prop('disabled' , true );
});
Created attachment 169859 [details] [review] Bug 37524: Do not attempt to renew check outs if there is nothing to renew If patrons loans are not renewable and one hits "Renew all" button in patrons "Check out" page, Koha is redirected to "Export data" tool. This happens because when there is nothing to renew call to function renew_all produces error: "Uncaught TypeError: renew_all(...) is undefined". This patch prevents call to this function and adds alert to inform user that there are no items to be renewed. To reproduce: 1. Find patron with check outs which renewals count has hit the maximum limit of renewals. 2. Press "Renew all" button. => Koha is redirected to "Export data" tool. 3. Apply this patch. 4. Try to renew check outs again. => Alert pop up is displayed. Sponsored-by: Koha-Suomi Oy Created attachment 169866 [details] [review] Bug 37524: Do not attempt to renew check outs if there is nothing to renew If patrons loans are not renewable and one hits "Renew all" button in patrons "Check out" page, Koha is redirected to "Export data" tool. This happens because when there is nothing to renew call to function renew_all produces error: "Uncaught TypeError: renew_all(...) is undefined". This patch prevents call to this function and adds alert to inform user that there are no items to be renewed. To reproduce: 1. Find patron with check outs which renewals count has hit the maximum limit of renewals. 2. Press "Renew all" button. => Koha is redirected to "Export data" tool. 3. Apply this patch. 4. Try to renew check outs again. => Alert pop up is displayed. Sponsored-by: Koha-Suomi Oy Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 171481 [details] [review] Bug 37524: Do not attempt to renew check outs if there is nothing to renew If patrons loans are not renewable and one hits "Renew all" button in patrons "Check out" page, Koha is redirected to "Export data" tool. This happens because when there is nothing to renew call to function renew_all produces error: "Uncaught TypeError: renew_all(...) is undefined". This patch prevents call to this function and adds alert to inform user that there are no items to be renewed. To reproduce: 1. Find patron with check outs which renewals count has hit the maximum limit of renewals. 2. Press "Renew all" button. => Koha is redirected to "Export data" tool. 3. Apply this patch. 4. Try to renew check outs again. => Alert pop up is displayed. Sponsored-by: Koha-Suomi Oy Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Created attachment 171482 [details] [review] Bug 37524: (QA follow-up) Tidy affected block in checkouts.js Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.06 |