Bug 37880 - Unwanted form submission on RenewAll button
Summary: Unwanted form submission on RenewAll button
Status: RESOLVED DUPLICATE of bug 37524
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-10 09:58 UTC by Peter Vashchuk
Modified: 2024-12-16 20:52 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 37880: Fix unwanted form submission on RenewAll button (1.34 KB, patch)
2024-09-10 10:01 UTC, Peter Vashchuk
Details | Diff | Splinter Review
Bug 37880: Fix unwanted form submission on RenewAll button (1.39 KB, patch)
2024-09-13 13:37 UTC, Olivier Vezina
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Vashchuk 2024-09-10 09:58:23 UTC

    
Comment 1 Peter Vashchuk 2024-09-10 10:01:10 UTC
Created attachment 171245 [details] [review]
Bug 37880: Fix unwanted form submission on RenewAll button

Currently when there's 0 renewable items and you press RenewAll button,
js does pointless form submission.

Steps to reproduce:
1. Have a patron with one or more holds that shouldn't be possible to renew.
2. Press RenewAll button.
3. Apply the patch.
4. Repeat step 2 but this time you should get "There is no items to renew." alert.
Comment 2 Olivier Vezina 2024-09-13 13:37:35 UTC
Created attachment 171458 [details] [review]
Bug 37880: Fix unwanted form submission on RenewAll button

Currently when there's 0 renewable items and you press RenewAll button,
js does pointless form submission.

Steps to reproduce:
1. Have a patron with one or more holds that shouldn't be possible to renew.
2. Press RenewAll button.
3. Apply the patch.
4. Repeat step 2 but this time you should get "There is no items to renew." alert.

Signed-off-by: Olivier V <olivier.vezina@inLibro.com>
Comment 3 Emily Lamancusa (emlam) 2024-12-16 20:52:08 UTC

*** This bug has been marked as a duplicate of bug 37524 ***