Description
Chris Cormack
2010-05-21 01:14:36 UTC
What is the status of this patch? I tested the behaviour in current HEAD: German templates are installed bot not checked in sys prefs language and opaclanguages. Language chooser is enabled and doesn't list German now. Language settings in Firefox list German as first language. Results: - Firefox opens OPAC in German - Firefox opens staff login in German - IE opens OPAC using German templates - IE opens staff loginin German Libraries should be able to decide in which languages they want to offer an OPAC, same for staff. The language detection in its current form causes some problems: - Customization is not done in a way that it works for all languages - CSS files are not copied over to all language folders - Templates are not updated - Translations are outdated or incomplete If we want to keep language detection (not sure we should) it should respect the language and opaclanguages sys prefs. This has been fixed in master (and 3.4.0) (In reply to comment #2) > This has been fixed in master (and 3.4.0) Sorry, I just tested this on 3.05.00.001 and it does not look fixed to me. The parts related to Porugues might be fixed, but not the problem described in the original bug report. Here's what I did: I have English and Norwegian installed, but only English enabled. When I set the language preference in my browser to English, I get the English interface - fine, no problem. When I set the language preference in my browser to Norwegian (either nb or nb-no), I get the Norwegian interface, even though that language has not been enabled. This is still a major problem This was fixed when patch for bug 7874 was pushed and the desired language (browser or cookie provided) started to get tested against the list of languages by this piece of code (@languages is get from the sysprefs, any is a map function for the test): # Ignore a lang not selected in sysprefs if ( $lang && any { $_ eq $lang } @languages ) { return $lang; } Marked resolved fixed then. |