Summary: | t/cypress/integration/ERM/DataProviders_spec.ts fails | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Test Suite | Assignee: | Matt Blenkinsop <matt.blenkinsop> |
Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, fridolin.somers, lucas, matt.blenkinsop, paul.derscheid, wainuiwitikapark |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
24.11.00,24.05.04,23.11.09
|
Circulation function: | |
Bug Depends on: | 37288 | ||
Bug Blocks: | |||
Attachments: |
Bug 37607: Only default to manual form if we are editing
Bug 37607: Only default to manual form if we are editing |
Description
Katrin Fischer
2024-08-09 15:19:38 UTC
Created attachment 170209 [details] [review] Bug 37607: Only default to manual form if we are editing This patch fixes an issue where the form to add a provder would automatically default to the manual form. This patch prevents this behaviour and restores the intended functionality. Test plan: 1) Don't apply the patch 2) In ERM, click to add a new provider 3) Type something in the provider name search box 4) The input will change from a select to a text input and the button next to it will now say "Create from registry" 5) Apply patch 6) Yarn build and hard refresh the browser 7) Repeat steps 1-3, the form should work as intended and return results in the select box Created attachment 170210 [details] [review] Bug 37607: Only default to manual form if we are editing This patch fixes an issue where the form to add a provder would automatically default to the manual form. This patch prevents this behaviour and restores the intended functionality. Test plan: 1) Don't apply the patch 2) In ERM, click to add a new provider 3) Type something in the provider name search box 4) The input will change from a select to a text input and the button next to it will now say "Create from registry" 5) Apply patch 6) Yarn build and hard refresh the browser 7) Repeat steps 1-3, the form should work as intended and return results in the select box Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.04 Pushed to 23.11.x for 23.11.09 Not backporting to 23.05.x unless requested Not backporting to 22.11 unless requested No changes required to the manual. |