Summary: | Clean up the form for sending cardnumbers from a report to batch patron modification | ||
---|---|---|---|
Product: | Koha | Reporter: | Phil Ringnalda <phil> |
Component: | Reports | Assignee: | Phil Ringnalda <phil> |
Status: | RESOLVED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, lucas, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This tidies up the form used when initiating patron batch modifications from a report that uses card numbers (option for 'Batch operations with X visible records'). There is no visible difference (the form that sends the card numbers to the patron batch modification form now puts them in a single text area, instead of multiple inputs).
|
Version(s) released in: |
24.11.00
|
Circulation function: | |||
Bug Depends on: | 37197 | ||
Bug Blocks: | |||
Attachments: |
Bug 37615: Clean up the form for sending cardnumbers from a report to batch patron modification
Bug 37615: Clean up the form for sending cardnumbers from a report to batch patron modification Bug 37615: Clean up the form for sending cardnumbers from a report to batch patron modification |
Description
Phil Ringnalda
2024-08-09 21:13:27 UTC
Created attachment 170413 [details] [review] Bug 37615: Clean up the form for sending cardnumbers from a report to batch patron modification Since bug 37197 switched reports back to using a POST to send cardnumbers to batch modification, we should also be using a single textarea rather than multiple inputs. Test plan: 1. Reports - Create from SQL - give it a name, and the SQL select cardnumber from borrowers limit 3 2. Save report - Run report 3. Batch operations with 3 visible records - Batch patron modification 4. Verify that you have the same three cardnumbers in Batch patron modification as were in the report. Created attachment 170420 [details] [review] Bug 37615: Clean up the form for sending cardnumbers from a report to batch patron modification Since bug 37197 switched reports back to using a POST to send cardnumbers to batch modification, we should also be using a single textarea rather than multiple inputs. Test plan: 1. Reports - Create from SQL - give it a name, and the SQL select cardnumber from borrowers limit 3 2. Save report - Run report 3. Batch operations with 3 visible records - Batch patron modification 4. Verify that you have the same three cardnumbers in Batch patron modification as were in the report. Signed-off-by: David Nind <david@davidnind.com> I have signed off. However, I noticed no visible difference before and after the patch was applied - and everything worked as expected, both before and after. Could you explain what is actually changing here - I don't see a text area, so the patch description does not make any sense to me. If there is nothing visible that changes when testing and that everything should work as expected (both before and after the patch), it would be useful to say that (for us mere mortals that don't necessarily understand developer speak!). If you want to see the difference, you can view source on the report results page, and search for modborrowers.pl - before you'll see three <input>s, after you'll see one <textarea>. Created attachment 170447 [details] [review] Bug 37615: Clean up the form for sending cardnumbers from a report to batch patron modification Since bug 37197 switched reports back to using a POST to send cardnumbers to batch modification, we should also be using a single textarea rather than multiple inputs. Test plan: 1. Reports - Create from SQL - give it a name, and the SQL select cardnumber from borrowers limit 3 2. Save report - Run report 3. Batch operations with 3 visible records - Batch patron modification 4. Verify that you have the same three cardnumbers in Batch patron modification as were in the report. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed for 24.11! Well done everyone, thank you! (In reply to Phil Ringnalda from comment #4) > If you want to see the difference, you can view source on the report results > page, and search for modborrowers.pl - before you'll see three <input>s, > after you'll see one <textarea>. Thanks for explaining! Doesn't apply cleanly to 24.05.x, no backport unless rebased. |