Description
Paul Derscheid
2024-08-12 10:07:54 UTC
Created attachment 170235 [details] [review] Bug 37618: Select patron's, then item's home library by default for pickup location when creating bookings I like the direction here.. will swing back around to it once I've wrapped my head around a few other bits in the bookings tree that are on my list for today. Created attachment 171384 [details] [review] Bug 37618: Select patron's, then item's home library by default for pickup location when creating bookings Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Just a rebase so far.. still testing :) Created attachment 171394 [details] [review] Bug 37618: (follow-up) Inline single use function containsAny and remove definition Created attachment 171395 [details] [review] Bug 37618: (follow-up) Remove redundant api call Unfortunately there's a bug here that persists the last selected option if neither the patron's nor the item's home library are valid pickup locations. (In reply to Paul Derscheid from comment #7) > Unfortunately there's a bug here that persists the last selected option if > neither the patron's nor the item's home library are valid pickup locations. Thanks for working this out, Paul! Created attachment 173155 [details] [review] Bug 37618: Select patron's, then item's home library by default for pickup location when creating bookings Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 173156 [details] [review] Bug 37618: (follow-up) Inline single use function containsAny and remove definition Created attachment 173157 [details] [review] Bug 37618: (follow-up) Remove redundant api call This is just a quick rebase and re-arrangement of the bug tree. There's some fixes in bug 37354 around these pickers that pre-exist thing but were only picked up during QA rounds there.. hense the rebase and hope it fixes some of the failure here. I'll be testing again imminently Created attachment 176924 [details] [review] Bug 37618: (follow-up) Prevent setting of incorrect default if no filtered pickup locations available That last patch does resolve comment #7 in local testing: > Unfortunately there's a bug here that persists the last selected option if neither the patron's nor the item's home library are valid pickup locations. |