| Summary: | Checkout slip prints out of order | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Circulation | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | Pushed to main --- | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | gmcharlt, kebliss, kyle.m.hall, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.11.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 37636: Remove sort of pending_checkouts by timestamp
Bug 37636: Remove sort of pending_checkouts by timestamp Bug 37636: Remove sort of pending_checkouts by timestamp Bug 37636: Unit test Bug 37636: Remove sort of pending_checkouts by timestamp Bug 37636: Unit test Bug 37636: Remove sort of pending_checkouts by timestamp |
||
|
Description
Nick Clemens (kidclamp)
2024-08-13 19:38:11 UTC
Created attachment 170496 [details] [review] Bug 37636: Remove sort of pending_checkouts by timestamp Renewals or automatic renewal attempts can change the timestamp of an issue and cause a sort on this field to functionally randomize the order of checkouts returned. Prior to bug 19935 the GetPendingCheckouts routine returned items in issuedate order. Removing the sort on timestamp will return the previous behaviour and provide a more predictable sorting To test: 1 - Checkout some items to a patron 2 - Print a checkout slip - items are in the order they were checked out 3 - Renew an item,print the slip again it is now at the top of the list 4 - Apply patch, restart_all 5 - Print slip again - the items are now ordered in the order they were checked out. Created attachment 170556 [details] [review] Bug 37636: Remove sort of pending_checkouts by timestamp Renewals or automatic renewal attempts can change the timestamp of an issue and cause a sort on this field to functionally randomize the order of checkouts returned. Prior to bug 19935 the GetPendingCheckouts routine returned items in issuedate order. Removing the sort on timestamp will return the previous behaviour and provide a more predictable sorting To test: 1 - Checkout some items to a patron 2 - Print a checkout slip - items are in the order they were checked out 3 - Renew an item,print the slip again it is now at the top of the list 4 - Apply patch, restart_all 5 - Print slip again - the items are now ordered in the order they were checked out. Signed-off-by: David Nind <david@davidnind.com> Created attachment 170558 [details] [review] Bug 37636: Remove sort of pending_checkouts by timestamp Renewals or automatic renewal attempts can change the timestamp of an issue and cause a sort on this field to functionally randomize the order of checkouts returned. Prior to bug 19935 the GetPendingCheckouts routine returned items in issuedate order. Removing the sort on timestamp will return the previous behaviour and provide a more predictable sorting To test: 1 - Checkout some items to a patron 2 - Print a checkout slip - items are in the order they were checked out 3 - Renew an item,print the slip again it is now at the top of the list 4 - Apply patch, restart_all 5 - Print slip again - the items are now ordered in the order they were checked out. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> I'm happy with the change.. but could we get a unit test for the ordering so we prevent future regression pretty please? Created attachment 170604 [details] [review] Bug 37636: Unit test Created attachment 170605 [details] [review] Bug 37636: Remove sort of pending_checkouts by timestamp Renewals or automatic renewal attempts can change the timestamp of an issue and cause a sort on this field to functionally randomize the order of checkouts returned. Prior to bug 19935 the GetPendingCheckouts routine returned items in issuedate order. Removing the sort on timestamp will return the previous behaviour and provide a more predictable sorting To test: 1 - Checkout some items to a patron 2 - Print a checkout slip - items are in the order they were checked out 3 - Renew an item,print the slip again it is now at the top of the list 4 - Apply patch, restart_all 5 - Print slip again - the items are now ordered in the order they were checked out. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 171453 [details] [review] Bug 37636: Unit test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 171454 [details] [review] Bug 37636: Remove sort of pending_checkouts by timestamp Renewals or automatic renewal attempts can change the timestamp of an issue and cause a sort on this field to functionally randomize the order of checkouts returned. Prior to bug 19935 the GetPendingCheckouts routine returned items in issuedate order. Removing the sort on timestamp will return the previous behaviour and provide a more predictable sorting To test: 1 - Checkout some items to a patron 2 - Print a checkout slip - items are in the order they were checked out 3 - Renew an item,print the slip again it is now at the top of the list 4 - Apply patch, restart_all 5 - Print slip again - the items are now ordered in the order they were checked out. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice one Nick, thanks for the unit tests Passing QA Pushed for 24.11! Well done everyone, thank you! |