Bug 37644

Summary: Let developers configure flatpickr defaultHour and defaultMinute via its config object
Product: Koha Reporter: Paul Derscheid <paul.derscheid>
Component: TemplatesAssignee: Paul Derscheid <paul.derscheid>
Status: Patch doesn't apply --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: lucas
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 37644: Let developers configure flatpickr defaultHour and defaultMinute via its config object
Bug 37644: Let developers configure flatpickr defaultHour and defaultMinute via its config object

Description Paul Derscheid 2024-08-14 09:36:48 UTC
Let's keep default hour and minute but allow developers to use flatpickr's config object as well for setting defaults (and that config taking precedence).
Comment 1 Paul Derscheid 2024-08-14 10:08:44 UTC
Created attachment 170313 [details] [review]
Bug 37644: Let developers configure flatpickr defaultHour and defaultMinute via its config object

To test:
1) Go to any flatpickr instance, for example in circulation.pl when setting a due date
2) Note that the default time 23:59 is set
3) Apply patch
4) Refresh
5) Note no change
6) Sign off
Comment 2 Owen Leonard 2024-08-14 11:49:12 UTC
Created attachment 170316 [details] [review]
Bug 37644: Let developers configure flatpickr defaultHour and defaultMinute via its config object

To test:
1) Go to any flatpickr instance, for example in circulation.pl when
   setting a due date
2) Note that the default time 23:59 is set
3) Apply patch
4) Refresh
5) Note no change
6) Sign off

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Lucas Gass (lukeg) 2024-11-22 18:36:24 UTC
Paul, unfortunately this one needs a rebase.