Bug 37644 - Let developers configure flatpickr defaultHour and defaultMinute via its config object
Summary: Let developers configure flatpickr defaultHour and defaultMinute via its conf...
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Paul Derscheid
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-14 09:36 UTC by Paul Derscheid
Modified: 2024-11-22 18:36 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 37644: Let developers configure flatpickr defaultHour and defaultMinute via its config object (1.68 KB, patch)
2024-08-14 10:08 UTC, Paul Derscheid
Details | Diff | Splinter Review
Bug 37644: Let developers configure flatpickr defaultHour and defaultMinute via its config object (1.73 KB, patch)
2024-08-14 11:49 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Derscheid 2024-08-14 09:36:48 UTC
Let's keep default hour and minute but allow developers to use flatpickr's config object as well for setting defaults (and that config taking precedence).
Comment 1 Paul Derscheid 2024-08-14 10:08:44 UTC
Created attachment 170313 [details] [review]
Bug 37644: Let developers configure flatpickr defaultHour and defaultMinute via its config object

To test:
1) Go to any flatpickr instance, for example in circulation.pl when setting a due date
2) Note that the default time 23:59 is set
3) Apply patch
4) Refresh
5) Note no change
6) Sign off
Comment 2 Owen Leonard 2024-08-14 11:49:12 UTC
Created attachment 170316 [details] [review]
Bug 37644: Let developers configure flatpickr defaultHour and defaultMinute via its config object

To test:
1) Go to any flatpickr instance, for example in circulation.pl when
   setting a due date
2) Note that the default time 23:59 is set
3) Apply patch
4) Refresh
5) Note no change
6) Sign off

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Lucas Gass (lukeg) 2024-11-22 18:36:24 UTC
Paul, unfortunately this one needs a rebase.