Summary: | Unnecessary use of Text::CSV_XS in Koha/REST/V1/ERM/EHoldings/Titles/Local.pm | ||
---|---|---|---|
Product: | Koha | Reporter: | Magnus Enger <magnus> |
Component: | ERM | Assignee: | Matt Blenkinsop <matt.blenkinsop> |
Status: | Needs documenting --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | fridolin.somers, jake.deery, jonathan.druart, jonathan.field, lucas, m.de.rooy, martin.renvoize, matt.blenkinsop, pedro.amorim |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.11.00,24.05.04
|
|
Circulation function: | |||
Bug Depends on: | 34788 | ||
Bug Blocks: | |||
Attachments: |
Bug 37647: Remove Text::CSV_XS import
Bug 37647: Remove Text::CSV_XS import Bug 37647: Remove Text::CSV_XS import |
Description
Magnus Enger
2024-08-15 09:07:03 UTC
Created attachment 170343 [details] [review] Bug 37647: Remove Text::CSV_XS import There is an unnecessary import that has been left over from when KBART file processing logic was being handled directly in the API controller. This patch removes that import as it is no longer needed Test plan: 1) Look at the patch diff and confirm that the import for Text::CSV_XS has been removed Created attachment 170344 [details] [review] Bug 37647: Remove Text::CSV_XS import There is an unnecessary import that has been left over from when KBART file processing logic was being handled directly in the API controller. This patch removes that import as it is no longer needed Test plan: 1) Look at the patch diff and confirm that the import for Text::CSV_XS has been removed Signed-off-by: Jake Deery <jake.deery@ptfs-europe.com> Test plan was confusing........ Only joking, signed off with thanks :-) Jake Created attachment 170427 [details] [review] Bug 37647: Remove Text::CSV_XS import There is an unnecessary import that has been left over from when KBART file processing logic was being handled directly in the API controller. This patch removes that import as it is no longer needed Test plan: 1) Look at the patch diff and confirm that the import for Text::CSV_XS has been removed Signed-off-by: Jake Deery <jake.deery@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.04 |