Bug 37647 - Unnecessary use of Text::CSV_XS in Koha/REST/V1/ERM/EHoldings/Titles/Local.pm
Summary: Unnecessary use of Text::CSV_XS in Koha/REST/V1/ERM/EHoldings/Titles/Local.pm
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Matt Blenkinsop
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 34788
Blocks:
  Show dependency treegraph
 
Reported: 2024-08-15 09:07 UTC by Magnus Enger
Modified: 2024-09-12 22:06 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.04
Circulation function:


Attachments
Bug 37647: Remove Text::CSV_XS import (1.05 KB, patch)
2024-08-15 09:39 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 37647: Remove Text::CSV_XS import (1.10 KB, patch)
2024-08-15 09:58 UTC, Jake Deery
Details | Diff | Splinter Review
Bug 37647: Remove Text::CSV_XS import (1.18 KB, patch)
2024-08-16 06:48 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Magnus Enger 2024-08-15 09:07:03 UTC
As far as I can see, there is a "use Text::CSV_XS;" at the top of Koha/REST/V1/ERM/EHoldings/Titles/Local.pm, but the module is not invoked anywhere in the script?
Comment 1 Matt Blenkinsop 2024-08-15 09:39:34 UTC
Created attachment 170343 [details] [review]
Bug 37647: Remove Text::CSV_XS import

There is an unnecessary import that has been left over from when KBART file processing logic was being handled directly in the API controller. This patch removes that import as it is no longer needed

Test plan:
1) Look at the patch diff and confirm that the import for Text::CSV_XS has been removed
Comment 2 Jake Deery 2024-08-15 09:58:53 UTC
Created attachment 170344 [details] [review]
Bug 37647: Remove Text::CSV_XS import

There is an unnecessary import that has been left over from when KBART file processing logic was being handled directly in the API controller. This patch removes that import as it is no longer needed

Test plan:
1) Look at the patch diff and confirm that the import for Text::CSV_XS has been removed

Signed-off-by: Jake Deery <jake.deery@ptfs-europe.com>
Comment 3 Jake Deery 2024-08-15 09:59:28 UTC
Test plan was confusing........ Only joking, signed off with thanks :-)

Jake
Comment 4 Marcel de Rooy 2024-08-16 06:48:07 UTC
Created attachment 170427 [details] [review]
Bug 37647: Remove Text::CSV_XS import

There is an unnecessary import that has been left over from when KBART file processing logic was being handled directly in the API controller. This patch removes that import as it is no longer needed

Test plan:
1) Look at the patch diff and confirm that the import for Text::CSV_XS has been removed

Signed-off-by: Jake Deery <jake.deery@ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Katrin Fischer 2024-08-19 15:31:19 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 6 Lucas Gass 2024-09-12 22:06:08 UTC
Backported to 24.05.x for upcoming 24.05.04