As far as I can see, there is a "use Text::CSV_XS;" at the top of Koha/REST/V1/ERM/EHoldings/Titles/Local.pm, but the module is not invoked anywhere in the script?
Created attachment 170343 [details] [review] Bug 37647: Remove Text::CSV_XS import There is an unnecessary import that has been left over from when KBART file processing logic was being handled directly in the API controller. This patch removes that import as it is no longer needed Test plan: 1) Look at the patch diff and confirm that the import for Text::CSV_XS has been removed
Created attachment 170344 [details] [review] Bug 37647: Remove Text::CSV_XS import There is an unnecessary import that has been left over from when KBART file processing logic was being handled directly in the API controller. This patch removes that import as it is no longer needed Test plan: 1) Look at the patch diff and confirm that the import for Text::CSV_XS has been removed Signed-off-by: Jake Deery <jake.deery@ptfs-europe.com>
Test plan was confusing........ Only joking, signed off with thanks :-) Jake
Created attachment 170427 [details] [review] Bug 37647: Remove Text::CSV_XS import There is an unnecessary import that has been left over from when KBART file processing logic was being handled directly in the API controller. This patch removes that import as it is no longer needed Test plan: 1) Look at the patch diff and confirm that the import for Text::CSV_XS has been removed Signed-off-by: Jake Deery <jake.deery@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.04
Depends on Bug 34788 not in 23.11.x