Summary: | V1/RecordSources.pm should use more helpers | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi <tomascohen> |
Component: | Architecture, internals, and plumbing | Assignee: | Tomás Cohen Arazi <tomascohen> |
Status: | Pushed to main --- | QA Contact: | Paul Derscheid <paul.derscheid> |
Severity: | minor | ||
Priority: | P5 - low | CC: | david, paul.derscheid, tomascohen |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37686 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.11.00
|
|
Circulation function: | |||
Bug Depends on: | 36495 | ||
Bug Blocks: | 37513 | ||
Attachments: |
Bug 37672: Make V1/RecordSources.pm use more helpers
Bug 37672: Add tests Bug 37672: Make V1/RecordSources.pm use more helpers Bug 37672: Add tests Bug 37672: Make V1/RecordSources.pm use more helpers Bug 37672: Add tests |
Description
Tomás Cohen Arazi
2024-08-19 12:22:01 UTC
Created attachment 170465 [details] [review] Bug 37672: Make V1/RecordSources.pm use more helpers This patch adapts the controller class to match the current guidelines by makiing use of the provided helpers. The tests are adapted. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 170467 [details] [review] Bug 37672: Add tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 170510 [details] [review] Bug 37672: Make V1/RecordSources.pm use more helpers This patch adapts the controller class to match the current guidelines by makiing use of the provided helpers. The tests are adapted. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Created attachment 170511 [details] [review] Bug 37672: Add tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. I ran the tests before and after the patches - they passed: prove t/db_dependent/api/v1/record_sources.t 2. I hope that is sufficient for sign off. Created attachment 170569 [details] [review] Bug 37672: Make V1/RecordSources.pm use more helpers This patch adapts the controller class to match the current guidelines by makiing use of the provided helpers. The tests are adapted. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Created attachment 170570 [details] [review] Bug 37672: Add tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> (In reply to David Nind from comment #5) > Testing notes (using KTD): > > 1. I ran the tests before and after the patches - they passed: > prove t/db_dependent/api/v1/record_sources.t > > 2. I hope that is sufficient for sign off. It is, thanks. Pushed for 24.11! Well done everyone, thank you! |