Bug 36495 was introduced and merged and bug 35919 didn't get adapted to it before getting merged. This is a minor thing but should be fixed.
Created attachment 170465 [details] [review] Bug 37672: Make V1/RecordSources.pm use more helpers This patch adapts the controller class to match the current guidelines by makiing use of the provided helpers. The tests are adapted. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 170467 [details] [review] Bug 37672: Add tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 170510 [details] [review] Bug 37672: Make V1/RecordSources.pm use more helpers This patch adapts the controller class to match the current guidelines by makiing use of the provided helpers. The tests are adapted. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 170511 [details] [review] Bug 37672: Add tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. I ran the tests before and after the patches - they passed: prove t/db_dependent/api/v1/record_sources.t 2. I hope that is sufficient for sign off.
Created attachment 170569 [details] [review] Bug 37672: Make V1/RecordSources.pm use more helpers This patch adapts the controller class to match the current guidelines by makiing use of the provided helpers. The tests are adapted. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Created attachment 170570 [details] [review] Bug 37672: Add tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
(In reply to David Nind from comment #5) > Testing notes (using KTD): > > 1. I ran the tests before and after the patches - they passed: > prove t/db_dependent/api/v1/record_sources.t > > 2. I hope that is sufficient for sign off. It is, thanks.
Pushed for 24.11! Well done everyone, thank you!