Bug 37672 - V1/RecordSources.pm should use more helpers
Summary: V1/RecordSources.pm should use more helpers
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Tomás Cohen Arazi
QA Contact: Paul Derscheid
URL:
Keywords:
Depends on: 36495
Blocks: 37513
  Show dependency treegraph
 
Reported: 2024-08-19 12:22 UTC by Tomás Cohen Arazi
Modified: 2024-08-23 16:22 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 37672: Make V1/RecordSources.pm use more helpers (2.84 KB, patch)
2024-08-19 12:29 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 37672: Add tests (1.56 KB, patch)
2024-08-19 12:55 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 37672: Make V1/RecordSources.pm use more helpers (2.88 KB, patch)
2024-08-21 04:05 UTC, David Nind
Details | Diff | Splinter Review
Bug 37672: Add tests (1.60 KB, patch)
2024-08-21 04:05 UTC, David Nind
Details | Diff | Splinter Review
Bug 37672: Make V1/RecordSources.pm use more helpers (2.94 KB, patch)
2024-08-21 15:12 UTC, Paul Derscheid
Details | Diff | Splinter Review
Bug 37672: Add tests (1.66 KB, patch)
2024-08-21 15:12 UTC, Paul Derscheid
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2024-08-19 12:22:01 UTC
Bug 36495 was introduced and merged and bug 35919 didn't get adapted to it before getting merged. This is a minor thing but should be fixed.
Comment 1 Tomás Cohen Arazi 2024-08-19 12:29:22 UTC
Created attachment 170465 [details] [review]
Bug 37672: Make V1/RecordSources.pm use more helpers

This patch adapts the controller class to match the current guidelines
by makiing use of the provided helpers.

The tests are adapted.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 Tomás Cohen Arazi 2024-08-19 12:55:48 UTC
Created attachment 170467 [details] [review]
Bug 37672: Add tests

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 David Nind 2024-08-21 04:05:57 UTC
Created attachment 170510 [details] [review]
Bug 37672: Make V1/RecordSources.pm use more helpers

This patch adapts the controller class to match the current guidelines
by makiing use of the provided helpers.

The tests are adapted.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2024-08-21 04:05:59 UTC
Created attachment 170511 [details] [review]
Bug 37672: Add tests

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2024-08-21 04:07:09 UTC
Testing notes (using KTD):

1. I ran the tests before and after the patches - they passed: 
   prove t/db_dependent/api/v1/record_sources.t

2. I hope that is sufficient for sign off.
Comment 6 Paul Derscheid 2024-08-21 15:12:14 UTC
Created attachment 170569 [details] [review]
Bug 37672: Make V1/RecordSources.pm use more helpers

This patch adapts the controller class to match the current guidelines
by makiing use of the provided helpers.

The tests are adapted.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 7 Paul Derscheid 2024-08-21 15:12:16 UTC
Created attachment 170570 [details] [review]
Bug 37672: Add tests

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 8 Tomás Cohen Arazi 2024-08-21 17:51:13 UTC
(In reply to David Nind from comment #5)
> Testing notes (using KTD):
> 
> 1. I ran the tests before and after the patches - they passed: 
>    prove t/db_dependent/api/v1/record_sources.t
> 
> 2. I hope that is sufficient for sign off.

It is, thanks.
Comment 9 Katrin Fischer 2024-08-23 16:22:41 UTC
Pushed for 24.11!

Well done everyone, thank you!