Bug 37698

Summary:	Setting Manual patron restriction type to 'Lift after payment' removes all manual restrictions
Product:	Koha	Reporter:	Sara Brown <sbrown>
Component:	System Administration	Assignee:	Bugs List <koha-bugs>
Status:	NEW ---	QA Contact:	Testopia <testopia>
Severity:	minor
Priority:	P5 - low	CC:	gmcharlt
Version:	24.05
Hardware:	All
OS:	All
See Also:	https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37689 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37690 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:

Description Sara Brown 2024-08-21 13:55:23 UTC

Bug 16223 - Automatically remove any borrower debarments after a payment allows libraries to automatically remove the MANUAL-type restriction placed by Bug 15157 - Cronjob to automatically restrict patrons with pending/unpaid charges using the debar_patrons_with_fines.pl cron. However, if a patron has a Manual restriction placed by that cron and a Manual restriction placed by staff for other reasons, and they pay their balance below the amount set in 'Fee limit' for the MANUAL restriction, all Manual-type restrictions are removed.

To replicate:
-In Administration > Patron restriction types, set 'Lift after payment?' to Yes and 'Fee limit' to $9.99 for the MANUAL restriction
-Set the debar_patrons_with_fines.pl cron to place restrictions for patrons owing over $10
-Add charges of $10 or more to a patron's account
-Run the cron to place the restriction - note the MANUAL restriction now showing on the patron's account
-Place a separate MANUAL restriction on the same patron's account
-Pay their fee so that the balance is at or below $9.99
-Note that both MANUAL restrictions have been removed

Only the restriction placed by the cron should be removed if fees are paid below the amount in 'Fee limit'. (See also: Bug 37689 - Add ability to select restriction type to use with debar_patrons_with_fines.pl to allow libraries to use other restriction types.)