| Summary: | Add Koha Objects for Koha Holidays | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Architecture, internals, and plumbing | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | Failed QA --- | QA Contact: | Victor Grousset/tuxayo <victor> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | ovezina, phil, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 37722: Add KOha Objects for Koha Holidays
Bug 37722: Add KOha Objects for Koha Holidays Bug 37722: (QA follow-up): fix copyright header |
||
|
Description
Nick Clemens (kidclamp)
2024-08-24 13:37:06 UTC
Created attachment 170688 [details] [review] Bug 37722: Add KOha Objects for Koha Holidays These patches add objects for special and repeating holidays To test: prove -v t/db_dependent/Koha/Holidays/ Created attachment 171995 [details] [review] Bug 37722: Add KOha Objects for Koha Holidays These patches add objects for special and repeating holidays To test: prove -v t/db_dependent/Koha/Holidays/ Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Created attachment 173188 [details] [review] Bug 37722: (QA follow-up): fix copyright header Looks like dead code: ``` use Koha::Database; ``` In Koha/Holidays/RepeatingHoliday.pm Koha/Holidays/RepeatingHolidays.pm Koha/Holidays/SpecialHoliday.pm Koha/Holidays/SpecialHolidays.pm --------- Any reason to switch from RepeatableHoliday (based on table name) to RepeatingHoliday? --------- commit title Bug 37722: Add KOha Objects for Koha Holidays Is a variation of the last case there: «Depending on the situation, it might be written "koha" or "Koha" or maybe even "KOHA". Writing "kOha" just means you got the shifting out of sync, though.» 😝😝😝 https://bugs.koha-community.org/bugzilla3/quips.cgi?action=show ----- All looks good otherwise :) |