37722 – Add Koha Objects for Koha Holidays

Bug 37722 - Add Koha Objects for Koha Holidays

Summary: Add Koha Objects for Koha Holidays

Status:	Failed QA

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Architecture, internals, and plumbing (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low enhancement
Assignee:	Nick Clemens (kidclamp)
QA Contact:	Victor Grousset/tuxayo

URL:
Keywords:

Depends on:
Blocks:

Reported:	2024-08-24 13:37 UTC by Nick Clemens (kidclamp)
Modified:	2024-10-24 00:23 UTC (History)
CC List:	3 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 37722: Add KOha Objects for Koha Holidays (13.46 KB, patch) 2024-08-24 13:42 UTC, Nick Clemens (kidclamp)	Details \| Diff \| Splinter Review
Bug 37722: Add KOha Objects for Koha Holidays (13.50 KB, patch) 2024-09-26 15:57 UTC, Olivier Vezina	Details \| Diff \| Splinter Review
Bug 37722: (QA follow-up): fix copyright header (1.23 KB, patch) 2024-10-23 02:10 UTC, Victor Grousset/tuxayo	Details \| Diff \| Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Nick Clemens (kidclamp) 2024-08-24 13:37:06 UTC

Comment 1 Nick Clemens (kidclamp) 2024-08-24 13:42:23 UTC

Created attachment 170688 [details] [review]
Bug 37722: Add KOha Objects for Koha Holidays

These patches add objects for special and repeating holidays

To test:
prove -v t/db_dependent/Koha/Holidays/

Comment 2 Olivier Vezina 2024-09-26 15:57:57 UTC

Created attachment 171995 [details] [review]
Bug 37722: Add KOha Objects for Koha Holidays

These patches add objects for special and repeating holidays

To test:
prove -v t/db_dependent/Koha/Holidays/

Signed-off-by: Olivier V <olivier.vezina@inLibro.com>

Comment 3 Victor Grousset/tuxayo 2024-10-23 02:10:10 UTC

Created attachment 173188 [details] [review]
Bug 37722: (QA follow-up): fix copyright header

Comment 4 Victor Grousset/tuxayo 2024-10-24 00:23:26 UTC

Looks like dead code:
```
use Koha::Database;
```

In
Koha/Holidays/RepeatingHoliday.pm
Koha/Holidays/RepeatingHolidays.pm
Koha/Holidays/SpecialHoliday.pm
Koha/Holidays/SpecialHolidays.pm



---------


Any reason to switch from RepeatableHoliday (based on table name) to RepeatingHoliday?


---------


commit title
Bug 37722: Add KOha Objects for Koha Holidays
Is a variation of the last case there:
«Depending on the situation, it might be written "koha" or "Koha" or maybe even "KOHA". Writing "kOha" just means you got the shifting out of sync, though.»
😝😝😝
https://bugs.koha-community.org/bugzilla3/quips.cgi?action=show



-----


All looks good otherwise :)