| Summary: | Preservation link in the header menu is not styled correctly | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Staff interface | Assignee: | Owen Leonard <oleonard> |
| Status: | Pushed to main --- | QA Contact: | Jonathan Druart <jonathan.druart> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | gmcharlt, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 35402 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 37733: Fix header menu style for preservation link
Bug 37733: Try to fix modal in the Preservation module Bug 37733: Fix header menu style for preservation link |
||
|
Description
Jonathan Druart
2024-08-26 12:59:19 UTC
Created attachment 170876 [details] [review] Bug 37733: Fix header menu style for preservation link This patch adds the missing "dropdown-item" class to the link in the header menu for the preservation module. To test, apply the patch and enable the preservation module (PreservationModule). Reload the page and click "More" in the header menu. The "Preservation" link should be styled like all the others. What about the other issues? Created attachment 170948 [details] [review] Bug 37733: Try to fix modal in the Preservation module We certainly need more as ERM module also use modals. And the Dialog component seems to have more elements affected. I guess we need to split this bug, but lacking time today. (In reply to Jonathan Druart from comment #0) > 1. "Preservation" does not appear styled in the "More" menu > > https://snipboard.io/6CmOWD.jpg > > 2. "Add to waiting list" modal is not centered > > http://localhost:8081/cgi-bin/koha/preservation/waiting-list > > https://snipboard.io/mIBYkj.jpg > > 3. Confirmation box "Are you sure you want to remove this item" is not > centered correctly > > https://snipboard.io/ZgJFGC.jpg Moved to bug 37812. Created attachment 170957 [details] [review] Bug 37733: Fix header menu style for preservation link This patch adds the missing "dropdown-item" class to the link in the header menu for the preservation module. To test, apply the patch and enable the preservation module (PreservationModule). Reload the page and click "More" in the header menu. The "Preservation" link should be styled like all the others. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Trivial, skipping QA. Pushed for 24.11! Well done everyone, thank you! |
