Bug 37733 - Preservation link in the header menu is not styled correctly
Summary: Preservation link in the header menu is not styled correctly
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on: 35402
Blocks:
  Show dependency tree / graph
 
Reported: 2024-08-26 12:59 UTC by Jonathan Druart
Modified: 2024-09-13 10:07 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:

Attachments
Bug 37733: Fix header menu style for preservation link (1.61 KB, patch)
2024-08-29 15:59 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 37733: Try to fix modal in the Preservation module (2.53 KB, patch)
2024-09-02 14:55 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 37733: Fix header menu style for preservation link (1.68 KB, patch)
2024-09-03 07:18 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-08-26 12:59:19 UTC 
1. "Preservation" does not appear styled in the "More" menu

https://snipboard.io/6CmOWD.jpg

2. "Add to waiting list" modal is not centered

http://localhost:8081/cgi-bin/koha/preservation/waiting-list 

https://snipboard.io/mIBYkj.jpg

3. Confirmation box "Are you sure you want to remove this item" is not centered correctly

https://snipboard.io/ZgJFGC.jpg
Comment 1 Owen Leonard 2024-08-29 15:59:12 UTC 
Created attachment 170876 [details] [review]
Bug 37733: Fix header menu style for preservation link

This patch adds the missing "dropdown-item" class to the link in the
header menu for the preservation module.

To test, apply the patch and enable the preservation module
(PreservationModule).

Reload the page and click "More" in the header menu. The "Preservation"
link should be styled like all the others.
Comment 2 Jonathan Druart 2024-09-02 13:55:02 UTC 
What about the other issues?
Comment 3 Jonathan Druart 2024-09-02 14:55:58 UTC 
Created attachment 170948 [details] [review]
Bug 37733: Try to fix modal in the Preservation module

We certainly need more as ERM module also use modals. And the Dialog
component seems to have more elements affected.
Comment 4 Jonathan Druart 2024-09-02 15:05:49 UTC 
I guess we need to split this bug, but lacking time today.
Comment 5 Jonathan Druart 2024-09-03 07:15:23 UTC 
(In reply to Jonathan Druart from comment #0)
> 1. "Preservation" does not appear styled in the "More" menu
> 
> https://snipboard.io/6CmOWD.jpg
> 
> 2. "Add to waiting list" modal is not centered
> 
> http://localhost:8081/cgi-bin/koha/preservation/waiting-list 
> 
> https://snipboard.io/mIBYkj.jpg
> 
> 3. Confirmation box "Are you sure you want to remove this item" is not
> centered correctly
> 
> https://snipboard.io/ZgJFGC.jpg

Moved to bug 37812.
Comment 6 Jonathan Druart 2024-09-03 07:18:48 UTC 
Created attachment 170957 [details] [review]
Bug 37733: Fix header menu style for preservation link

This patch adds the missing "dropdown-item" class to the link in the
header menu for the preservation module.

To test, apply the patch and enable the preservation module
(PreservationModule).

Reload the page and click "More" in the header menu. The "Preservation"
link should be styled like all the others.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 Jonathan Druart 2024-09-03 07:19:07 UTC 
Trivial, skipping QA.
Comment 8 Katrin Fischer 2024-09-13 10:07:39 UTC 
Pushed for 24.11!

Well done everyone, thank you!