Summary: | Can't delete vendors after Bootstrap 5 update | ||
---|---|---|---|
Product: | Koha | Reporter: | David Nind <david> |
Component: | Staff interface | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | RESOLVED FIXED | QA Contact: | Lucas Gass (lukeg) <lucas> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes acquisitions so that you can now delete vendors. (This is related to the OPAC and staff interface Bootstrap 5 upgrade in Koha 24.11 (bug 35402) and bug 31921, which added a confirmation pop-up window when deleting a vendor.)
|
Version(s) released in: |
24.11.00
|
Circulation function: | |||
Bug Depends on: | 35402 | ||
Bug Blocks: | |||
Attachments: |
Bug 37739: Adjust vendor deletion modal code after bootstrap 5 update
Bug 37739: Adjust vendor deletion modal code after bootstrap 5 update Bug 37739: Adjust vendor deletion modal code after bootstrap 5 update Bug 37739: (follow-up) Add extra space in markup |
Description
David Nind
2024-08-26 22:09:43 UTC
Created attachment 170751 [details] [review] Bug 37739: Adjust vendor deletion modal code after bootstrap 5 update This patch fixes a conflict between bug 31921 and bug 35402. Test plan: Create a vendor then delete it using the "Delete vendor" button Confirm that the modal looks like other modals in Koha. Click the "x", "No" and "Yes". Confirm that "x" and "no" close the modal but "yes" correctly delete the vendor. Created attachment 170792 [details] [review] Bug 37739: Adjust vendor deletion modal code after bootstrap 5 update This patch fixes a conflict between bug 31921 and bug 35402. Test plan: Create a vendor then delete it using the "Delete vendor" button Confirm that the modal looks like other modals in Koha. Click the "x", "No" and "Yes". Confirm that "x" and "no" close the modal but "yes" correctly delete the vendor. Signed-off-by: David Nind <david@davidnind.com> Created attachment 170822 [details] [review] Bug 37739: Adjust vendor deletion modal code after bootstrap 5 update This patch fixes a conflict between bug 31921 and bug 35402. Test plan: Create a vendor then delete it using the "Delete vendor" button Confirm that the modal looks like other modals in Koha. Click the "x", "No" and "Yes". Confirm that "x" and "no" close the modal but "yes" correctly delete the vendor. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 170823 [details] [review] Bug 37739: (follow-up) Add extra space in markup Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Pushed for 24.11! Well done everyone, thank you! |