Bug 37739 - Can't delete vendors after Bootstrap 5 update
Summary: Can't delete vendors after Bootstrap 5 update
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Lucas Gass
URL:
Keywords:
Depends on: 35402
Blocks:
  Show dependency treegraph
 
Reported: 2024-08-26 22:09 UTC by David Nind
Modified: 2024-08-29 15:25 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes acquisitions so that you can now delete vendors. (This is related to the OPAC and staff interface Bootstrap 5 upgrade in Koha 24.11 (bug 35402) and bug 31921, which added a confirmation pop-up window when deleting a vendor.)
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 37739: Adjust vendor deletion modal code after bootstrap 5 update (3.53 KB, patch)
2024-08-27 09:41 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 37739: Adjust vendor deletion modal code after bootstrap 5 update (3.57 KB, patch)
2024-08-28 00:18 UTC, David Nind
Details | Diff | Splinter Review
Bug 37739: Adjust vendor deletion modal code after bootstrap 5 update (3.63 KB, patch)
2024-08-28 14:22 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 37739: (follow-up) Add extra space in markup (1.39 KB, patch)
2024-08-28 14:22 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Nind 2024-08-26 22:09:43 UTC
After the Bootstrap 5 update (bug 35402) you can no longer delete vendors.

To test that deleting a vendor doesn't work after the Bootstrap 5 update:
1. Start up KTD with the latest main.
2. Go to Acquisitions > Manage orders section - select the 'Search' button.
3. Add two or three new vendors:
   . + New vendor
   . Name: Vendor 1, 2, 3 and so on
4. List all the vendors: Acquisitions > Manage orders section - select the 'Search' button.
5. Select 'Delete vendor' for any of the newly created vendors.
6. Note that nothing happens.
7. Note that there are no console errors if you use the browser web developer tools.

To test that deleting a vendor works before the Bootstrap 5 update:
1. Check out the Koha git repository before the Bootstrap update: git checkout f44d2cccc7
2. Shut down KTD.
3. Start up KTD again.
4. Go to Acquisitions > Manage orders section - select the 'Search' button.
5. Add three or four new vendors:
   . + New vendor
   . Name: Vendor 1, 2, 3 and so on
6. List all the vendors: Acquisitions > Manage orders section - select the 'Search' button.
7. Select 'Delete vendor' for any of the newly created vendors.
8. In a pop-up window, you are prompted "Are you sure you want to delete this vendor?".
9. Select 'Yes'.
10. Go to Acquisitions > Manage orders section - select the 'Search' button.
11. The vendor you deleted is no longer listed.

(Note: After starting up KTD again on main, I had to do a yarn install, yarn build, and restart_all.)
Comment 1 Jonathan Druart 2024-08-27 09:41:09 UTC
Created attachment 170751 [details] [review]
Bug 37739: Adjust vendor deletion modal code after bootstrap 5 update

This patch fixes a conflict between bug 31921 and bug 35402.

Test plan:
Create a vendor then delete it using the "Delete vendor" button
Confirm that the modal looks like other modals in Koha.
Click the "x", "No" and "Yes". Confirm that "x" and "no" close the modal
but "yes" correctly delete the vendor.
Comment 2 David Nind 2024-08-28 00:18:48 UTC
Created attachment 170792 [details] [review]
Bug 37739: Adjust vendor deletion modal code after bootstrap 5 update

This patch fixes a conflict between bug 31921 and bug 35402.

Test plan:
Create a vendor then delete it using the "Delete vendor" button
Confirm that the modal looks like other modals in Koha.
Click the "x", "No" and "Yes". Confirm that "x" and "no" close the modal
but "yes" correctly delete the vendor.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Lucas Gass 2024-08-28 14:22:36 UTC
Created attachment 170822 [details] [review]
Bug 37739: Adjust vendor deletion modal code after bootstrap 5 update

This patch fixes a conflict between bug 31921 and bug 35402.

Test plan:
Create a vendor then delete it using the "Delete vendor" button
Confirm that the modal looks like other modals in Koha.
Click the "x", "No" and "Yes". Confirm that "x" and "no" close the modal
but "yes" correctly delete the vendor.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Lucas Gass 2024-08-28 14:22:38 UTC
Created attachment 170823 [details] [review]
Bug 37739: (follow-up) Add extra space in markup

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 5 Katrin Fischer 2024-08-29 15:25:25 UTC
Pushed for 24.11!

Well done everyone, thank you!