After the Bootstrap 5 update (bug 35402) you can no longer delete vendors. To test that deleting a vendor doesn't work after the Bootstrap 5 update: 1. Start up KTD with the latest main. 2. Go to Acquisitions > Manage orders section - select the 'Search' button. 3. Add two or three new vendors: . + New vendor . Name: Vendor 1, 2, 3 and so on 4. List all the vendors: Acquisitions > Manage orders section - select the 'Search' button. 5. Select 'Delete vendor' for any of the newly created vendors. 6. Note that nothing happens. 7. Note that there are no console errors if you use the browser web developer tools. To test that deleting a vendor works before the Bootstrap 5 update: 1. Check out the Koha git repository before the Bootstrap update: git checkout f44d2cccc7 2. Shut down KTD. 3. Start up KTD again. 4. Go to Acquisitions > Manage orders section - select the 'Search' button. 5. Add three or four new vendors: . + New vendor . Name: Vendor 1, 2, 3 and so on 6. List all the vendors: Acquisitions > Manage orders section - select the 'Search' button. 7. Select 'Delete vendor' for any of the newly created vendors. 8. In a pop-up window, you are prompted "Are you sure you want to delete this vendor?". 9. Select 'Yes'. 10. Go to Acquisitions > Manage orders section - select the 'Search' button. 11. The vendor you deleted is no longer listed. (Note: After starting up KTD again on main, I had to do a yarn install, yarn build, and restart_all.)
Created attachment 170751 [details] [review] Bug 37739: Adjust vendor deletion modal code after bootstrap 5 update This patch fixes a conflict between bug 31921 and bug 35402. Test plan: Create a vendor then delete it using the "Delete vendor" button Confirm that the modal looks like other modals in Koha. Click the "x", "No" and "Yes". Confirm that "x" and "no" close the modal but "yes" correctly delete the vendor.
Created attachment 170792 [details] [review] Bug 37739: Adjust vendor deletion modal code after bootstrap 5 update This patch fixes a conflict between bug 31921 and bug 35402. Test plan: Create a vendor then delete it using the "Delete vendor" button Confirm that the modal looks like other modals in Koha. Click the "x", "No" and "Yes". Confirm that "x" and "no" close the modal but "yes" correctly delete the vendor. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 170822 [details] [review] Bug 37739: Adjust vendor deletion modal code after bootstrap 5 update This patch fixes a conflict between bug 31921 and bug 35402. Test plan: Create a vendor then delete it using the "Delete vendor" button Confirm that the modal looks like other modals in Koha. Click the "x", "No" and "Yes". Confirm that "x" and "no" close the modal but "yes" correctly delete the vendor. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 170823 [details] [review] Bug 37739: (follow-up) Add extra space in markup Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Pushed for 24.11! Well done everyone, thank you!