Bug 37752

Summary: Tabs for MARC subfield structure are missing a class
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: Staff interfaceAssignee: Lucas Gass (lukeg) <lucas>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: david, gmcharlt, jonathan.druart
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37753
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
This fixes the navigation display when editing bibliographic framework subfields. It was displaying a plain text link for each subfield in the header, instead of the standard tabbed style. (This is related to the OPAC and staff interface Bootstrap 5 upgrade in Koha 24.11.)
Version(s) released in:
24.11.00
Circulation function:
Bug Depends on: 35402    
Bug Blocks:    
Attachments: Bug 37752: Add missing class to navigation tab links
Bug 37752: Add missing class to navigation tab links
Bug 37752: Add missing class to navigation tab links

Description Lucas Gass (lukeg) 2024-08-27 20:10:44 UTC
To recreate:
1. Go to  Administration > MARC bibliographic frameworks > Default framework Tag 942 > subfield structure 
2. Notice the tabs at the top have no style.
Comment 1 Lucas Gass (lukeg) 2024-08-27 20:12:25 UTC
Created attachment 170783 [details] [review]
Bug 37752: Add missing class to navigation tab links

To test:
1. Go to  Administration > MARC bibliographic frameworks > Default framework Tag 942 > subfield structure
2. Notice the tabs at the top have no style.
3. APPLY PATCH
4. 1 -3 again, tabs should look right.
Comment 2 David Nind 2024-08-27 22:54:02 UTC
Created attachment 170791 [details] [review]
Bug 37752: Add missing class to navigation tab links

To test:
1. Go to  Administration > MARC bibliographic frameworks > Default framework Tag 942 > subfield structure
2. Notice the tabs at the top have no style.
3. APPLY PATCH
4. 1 -3 again, tabs should look right.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2024-08-27 23:44:40 UTC
This is also the case for authority types - I have created bug 37753 for this.
Comment 4 Jonathan Druart 2024-08-29 10:53:30 UTC
Created attachment 170863 [details] [review]
Bug 37752: Add missing class to navigation tab links

To test:
1. Go to  Administration > MARC bibliographic frameworks > Default framework Tag 942 > subfield structure
2. Notice the tabs at the top have no style.
3. APPLY PATCH
4. 1 -3 again, tabs should look right.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Katrin Fischer 2024-08-29 15:10:12 UTC
Can we please get a fix for the authority types as well?
Comment 6 Katrin Fischer 2024-08-29 15:11:44 UTC
Ah, next in my queue: bug 37753. It's done!
Comment 7 Katrin Fischer 2024-08-29 15:25:31 UTC
Pushed for 24.11!

Well done everyone, thank you!