Bug 37752 - Tabs for MARC subfield structure are missing a class
Summary: Tabs for MARC subfield structure are missing a class
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Testopia
URL:
Keywords:
Depends on: 35402
Blocks:
  Show dependency tree / graph
 
Reported: 2024-08-27 20:10 UTC by Lucas Gass (lukeg)
Modified: 2024-11-15 20:24 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the navigation display when editing bibliographic framework subfields. It was displaying a plain text link for each subfield in the header, instead of the standard tabbed style. (This is related to the OPAC and staff interface Bootstrap 5 upgrade in Koha 24.11.)
Version(s) released in:
24.11.00
Circulation function:

Attachments
Bug 37752: Add missing class to navigation tab links (2.69 KB, patch)
2024-08-27 20:12 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 37752: Add missing class to navigation tab links (2.74 KB, patch)
2024-08-27 22:54 UTC, David Nind 		Details | Diff | Splinter Review
Bug 37752: Add missing class to navigation tab links (2.81 KB, patch)
2024-08-29 10:53 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2024-08-27 20:10:44 UTC 
To recreate:
1. Go to  Administration > MARC bibliographic frameworks > Default framework Tag 942 > subfield structure 
2. Notice the tabs at the top have no style.
Comment 1 Lucas Gass (lukeg) 2024-08-27 20:12:25 UTC 
Created attachment 170783 [details] [review]
Bug 37752: Add missing class to navigation tab links

To test:
1. Go to  Administration > MARC bibliographic frameworks > Default framework Tag 942 > subfield structure
2. Notice the tabs at the top have no style.
3. APPLY PATCH
4. 1 -3 again, tabs should look right.
Comment 2 David Nind 2024-08-27 22:54:02 UTC 
Created attachment 170791 [details] [review]
Bug 37752: Add missing class to navigation tab links

To test:
1. Go to  Administration > MARC bibliographic frameworks > Default framework Tag 942 > subfield structure
2. Notice the tabs at the top have no style.
3. APPLY PATCH
4. 1 -3 again, tabs should look right.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2024-08-27 23:44:40 UTC 
This is also the case for authority types - I have created bug 37753 for this.
Comment 4 Jonathan Druart 2024-08-29 10:53:30 UTC 
Created attachment 170863 [details] [review]
Bug 37752: Add missing class to navigation tab links

To test:
1. Go to  Administration > MARC bibliographic frameworks > Default framework Tag 942 > subfield structure
2. Notice the tabs at the top have no style.
3. APPLY PATCH
4. 1 -3 again, tabs should look right.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Katrin Fischer 2024-08-29 15:10:12 UTC 
Can we please get a fix for the authority types as well?
Comment 6 Katrin Fischer 2024-08-29 15:11:44 UTC 
Ah, next in my queue: bug 37753. It's done!
Comment 7 Katrin Fischer 2024-08-29 15:25:31 UTC 
Pushed for 24.11!

Well done everyone, thank you!