| Summary: | Duplicated "Set library" menu item caused by bad merge | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | Pushed to main --- | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | ||
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 35402 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 37759: Duplicated "Set library" menu item caused by bad merge
Bug 37759: Duplicated "Set library" menu item caused by bad merge Bug 37759: Duplicated "Set library" menu item caused by bad merge Bug 37759: Duplicated "Set library" menu item caused by bad merge |
||
|
Description
Owen Leonard
2024-08-28 13:31:10 UTC
Created attachment 170825 [details] [review] Bug 37759: Duplicated "Set library" menu item caused by bad merge This patch removes an unnecessary block of markup accidentally left behind during a rebase of Bug 35402, removing a duplicate "Set library..." menu item from the header menu in the staff interface. After the batch, users who have permission to change their logged-in library should see only a single "Set library..." menu item in the user menu found on the right-hand side of the header menu. Created attachment 170837 [details] [review] Bug 37759: Duplicated "Set library" menu item caused by bad merge This patch removes an unnecessary block of markup accidentally left behind during a rebase of Bug 35402, removing a duplicate "Set library..." menu item from the header menu in the staff interface. After the batch, users who have permission to change their logged-in library should see only a single "Set library..." menu item in the user menu found on the right-hand side of the header menu. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 170865 [details] [review] Bug 37759: Duplicated "Set library" menu item caused by bad merge This patch removes an unnecessary block of markup accidentally left behind during a rebase of Bug 35402, removing a duplicate "Set library..." menu item from the header menu in the staff interface. After the batch, users who have permission to change their logged-in library should see only a single "Set library..." menu item in the user menu found on the right-hand side of the header menu. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Hm, I tried to rebase, but now the "gear" icon does nothing. Can you please check yourself and rebase against latest master? Going to push a batch of changes in just a little bit. Created attachment 170875 [details] [review] Bug 37759: Duplicated "Set library" menu item caused by bad merge This patch removes an unnecessary block of markup accidentally left behind during a rebase of Bug 35402, removing a duplicate "Set library..." menu item from the header menu in the staff interface. After the batch, users who have permission to change their logged-in library should see only a single "Set library..." menu item in the user menu found on the right-hand side of the header menu. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed for 24.11! Well done everyone, thank you! |