In the rebasing of Bug 35402 I made a mistake in updating header.inc, including a section which should have been removed. This has caused a duplicate "Set library" menu item in the staff interface header.
Created attachment 170825 [details] [review] Bug 37759: Duplicated "Set library" menu item caused by bad merge This patch removes an unnecessary block of markup accidentally left behind during a rebase of Bug 35402, removing a duplicate "Set library..." menu item from the header menu in the staff interface. After the batch, users who have permission to change their logged-in library should see only a single "Set library..." menu item in the user menu found on the right-hand side of the header menu.
Created attachment 170837 [details] [review] Bug 37759: Duplicated "Set library" menu item caused by bad merge This patch removes an unnecessary block of markup accidentally left behind during a rebase of Bug 35402, removing a duplicate "Set library..." menu item from the header menu in the staff interface. After the batch, users who have permission to change their logged-in library should see only a single "Set library..." menu item in the user menu found on the right-hand side of the header menu. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Created attachment 170865 [details] [review] Bug 37759: Duplicated "Set library" menu item caused by bad merge This patch removes an unnecessary block of markup accidentally left behind during a rebase of Bug 35402, removing a duplicate "Set library..." menu item from the header menu in the staff interface. After the batch, users who have permission to change their logged-in library should see only a single "Set library..." menu item in the user menu found on the right-hand side of the header menu. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Hm, I tried to rebase, but now the "gear" icon does nothing. Can you please check yourself and rebase against latest master? Going to push a batch of changes in just a little bit.
Created attachment 170875 [details] [review] Bug 37759: Duplicated "Set library" menu item caused by bad merge This patch removes an unnecessary block of markup accidentally left behind during a rebase of Bug 35402, removing a duplicate "Set library..." menu item from the header menu in the staff interface. After the batch, users who have permission to change their logged-in library should see only a single "Set library..." menu item in the user menu found on the right-hand side of the header menu. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed for 24.11! Well done everyone, thank you!