Bug 37764

Summary: 'Fix handling of "All" values on waiting hold cancellation policy' breaks Koha
Product: Koha Reporter: David Cook <dcook>
Component: Fines and feesAssignee: Bugs List <koha-bugs>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low    
Version: 23.11   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 37255    
Bug Blocks:    

Description David Cook 2024-08-29 02:34:04 UTC
Bug 37255 was backported too far and has broken the smart-rules.tt for anyone who has an "All" value in "Default waiting hold cancellation policy" in the circ rules.
Comment 1 David Cook 2024-08-29 02:34:26 UTC
See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255#c18

This only affects 23.11 and older.
Comment 2 Katrin Fischer 2024-08-29 07:56:08 UTC
Please see my note on 37255:
> You need to look at the latest tag: 23.11.08-1. That's what we used for the
> tarballs and packages. It has the revert on top:
> 
> https://git.koha-community.org/Koha-community/Koha/commits/tag/v23.11.08-1
Comment 3 David Cook 2024-08-30 00:22:40 UTC
(In reply to Katrin Fischer from comment #2)
> Please see my note on 37255:
> > You need to look at the latest tag: 23.11.08-1. That's what we used for the
> > tarballs and packages. It has the revert on top:
> > 
> > https://git.koha-community.org/Koha-community/Koha/commits/tag/v23.11.08-1

Ahhhhhhhhhhhhh. My bad.