| Summary: | Fix terminology 'Biblio not found' | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | REST API | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | RESOLVED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | lucas, martin.renvoize, ovezina, tomascohen |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 37686 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 37791: Fix 'Biblio not found' messages on the API
Bug 37791: (follow-up) Last occurence Bug 37791: Fix 'Biblio not found' messages on the API Bug 37791: (follow-up) Last occurence Bug 37791: Fix 'Biblio not found' messages on the API Bug 37791: (follow-up) Last occurence |
||
|
Description
Tomás Cohen Arazi (tcohen)
2024-08-30 11:18:04 UTC
And also these here:
return $c->render_resource_not_found("Biblio");
The should all be changed to read: Bibliographic record
(In reply to Katrin Fischer from comment #1) > And also these here: > return $c->render_resource_not_found("Biblio"); > > The should all be changed to read: Bibliographic record Yes, that is the main target for this bug. Created attachment 170903 [details] [review] Bug 37791: Fix 'Biblio not found' messages on the API This patch fixes some API-related cases of 'Biblio' terminology incorrectly used. To test: 1. Run: $ ktd --shell k$ git grep 'Biblio not found' => FAIL: Several occurences 2. Run: k$ git grep 'render_resource_not_found("Biblio")' => FAIL: Several occurences 3. Apply this patches 4. Repeat 1 and 2 => SUCCESS: No more occurences! 5. Run: k$ prove t/db_dependent/api/v1/ => SUCCESS: Tests pass! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 170904 [details] [review] Bug 37791: (follow-up) Last occurence Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 171493 [details] [review] Bug 37791: Fix 'Biblio not found' messages on the API This patch fixes some API-related cases of 'Biblio' terminology incorrectly used. To test: 1. Run: $ ktd --shell k$ git grep 'Biblio not found' => FAIL: Several occurences 2. Run: k$ git grep 'render_resource_not_found("Biblio")' => FAIL: Several occurences 3. Apply this patches 4. Repeat 1 and 2 => SUCCESS: No more occurences! 5. Run: k$ prove t/db_dependent/api/v1/ => SUCCESS: Tests pass! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Created attachment 171494 [details] [review] Bug 37791: (follow-up) Last occurence Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Created attachment 171617 [details] [review] Bug 37791: Fix 'Biblio not found' messages on the API This patch fixes some API-related cases of 'Biblio' terminology incorrectly used. To test: 1. Run: $ ktd --shell k$ git grep 'Biblio not found' => FAIL: Several occurences 2. Run: k$ git grep 'render_resource_not_found("Biblio")' => FAIL: Several occurences 3. Apply this patches 4. Repeat 1 and 2 => SUCCESS: No more occurences! 5. Run: k$ prove t/db_dependent/api/v1/ => SUCCESS: Tests pass! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 171618 [details] [review] Bug 37791: (follow-up) Last occurence Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Pushed for 24.11! Well done everyone, thank you! Missing deps for 24.05.x |