Bug 37791 - Fix terminology 'Biblio not found'
Summary: Fix terminology 'Biblio not found'
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: REST API (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Tomás Cohen Arazi (tcohen)
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on: 37686
Blocks:
  Show dependency treegraph
 
Reported: 2024-08-30 11:18 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2024-10-11 10:27 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 37791: Fix 'Biblio not found' messages on the API (9.02 KB, patch)
2024-08-30 11:44 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 37791: (follow-up) Last occurence (1.52 KB, patch)
2024-08-30 11:44 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 37791: Fix 'Biblio not found' messages on the API (9.05 KB, patch)
2024-09-13 18:58 UTC, Olivier Vezina
Details | Diff | Splinter Review
Bug 37791: (follow-up) Last occurence (1.57 KB, patch)
2024-09-13 18:58 UTC, Olivier Vezina
Details | Diff | Splinter Review
Bug 37791: Fix 'Biblio not found' messages on the API (9.14 KB, patch)
2024-09-17 12:29 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 37791: (follow-up) Last occurence (1.64 KB, patch)
2024-09-17 12:29 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2024-08-30 11:18:04 UTC
There are places in which this text is generated. In particular, on the API spec.
Comment 1 Katrin Fischer 2024-08-30 11:35:37 UTC
And also these here:
 return $c->render_resource_not_found("Biblio");

The should all be changed to read: Bibliographic record
Comment 2 Tomás Cohen Arazi (tcohen) 2024-08-30 11:36:43 UTC
(In reply to Katrin Fischer from comment #1)
> And also these here:
>  return $c->render_resource_not_found("Biblio");
> 
> The should all be changed to read: Bibliographic record

Yes, that is the main target for this bug.
Comment 3 Tomás Cohen Arazi (tcohen) 2024-08-30 11:44:27 UTC
Created attachment 170903 [details] [review]
Bug 37791: Fix 'Biblio not found' messages on the API

This patch fixes some API-related cases of 'Biblio' terminology
incorrectly used.

To test:
1. Run:
   $ ktd --shell
  k$ git grep 'Biblio not found'
=> FAIL: Several occurences
2. Run:
  k$ git grep 'render_resource_not_found("Biblio")'
=> FAIL: Several occurences
3. Apply this patches
4. Repeat 1 and 2
=> SUCCESS: No more occurences!
5. Run:
  k$ prove t/db_dependent/api/v1/
=> SUCCESS: Tests pass!
6. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Tomás Cohen Arazi (tcohen) 2024-08-30 11:44:30 UTC
Created attachment 170904 [details] [review]
Bug 37791: (follow-up) Last occurence

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 5 Olivier Vezina 2024-09-13 18:58:45 UTC
Created attachment 171493 [details] [review]
Bug 37791: Fix 'Biblio not found' messages on the API

This patch fixes some API-related cases of 'Biblio' terminology
incorrectly used.

To test:
1. Run:
   $ ktd --shell
  k$ git grep 'Biblio not found'
=> FAIL: Several occurences
2. Run:
  k$ git grep 'render_resource_not_found("Biblio")'
=> FAIL: Several occurences
3. Apply this patches
4. Repeat 1 and 2
=> SUCCESS: No more occurences!
5. Run:
  k$ prove t/db_dependent/api/v1/
=> SUCCESS: Tests pass!
6. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Olivier V <olivier.vezina@inLibro.com>
Comment 6 Olivier Vezina 2024-09-13 18:58:46 UTC
Created attachment 171494 [details] [review]
Bug 37791: (follow-up) Last occurence

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Olivier V <olivier.vezina@inLibro.com>
Comment 7 Martin Renvoize (ashimema) 2024-09-17 12:29:04 UTC
Created attachment 171617 [details] [review]
Bug 37791: Fix 'Biblio not found' messages on the API

This patch fixes some API-related cases of 'Biblio' terminology
incorrectly used.

To test:
1. Run:
   $ ktd --shell
  k$ git grep 'Biblio not found'
=> FAIL: Several occurences
2. Run:
  k$ git grep 'render_resource_not_found("Biblio")'
=> FAIL: Several occurences
3. Apply this patches
4. Repeat 1 and 2
=> SUCCESS: No more occurences!
5. Run:
  k$ prove t/db_dependent/api/v1/
=> SUCCESS: Tests pass!
6. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Olivier V <olivier.vezina@inLibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 8 Martin Renvoize (ashimema) 2024-09-17 12:29:06 UTC
Created attachment 171618 [details] [review]
Bug 37791: (follow-up) Last occurence

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Olivier V <olivier.vezina@inLibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 9 Katrin Fischer 2024-10-11 10:27:40 UTC
Pushed for 24.11!

Well done everyone, thank you!