Summary: | XXX trick in installer code is not longer needed | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Installation and upgrade (command-line installer) | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | RESOLVED FIXED | QA Contact: | Julian Maurice <julian.maurice> |
Severity: | minor | ||
Priority: | P5 - low | CC: | david, julian.maurice, lucas, tomascohen |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34088 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.11.00
|
|
Circulation function: | |||
Bug Depends on: | 13068 | ||
Bug Blocks: | |||
Attachments: |
Bug 37818: Remove 'XXX' from the installer code
Bug 37818: Remove 'XXX' from the installer code Bug 37818: Remove 'XXX' from the installer code Bug 37818: (follow-up) Remove failing XXX tests from Installer.t |
Description
Jonathan Druart
2024-09-03 09:43:12 UTC
Created attachment 170964 [details] [review] Bug 37818: Remove 'XXX' from the installer code We were adding "XXX" that was replaced with "999" before the move to the atomic update files (bug 13068). We do no longer need this code. Created attachment 170976 [details] [review] Bug 37818: Remove 'XXX' from the installer code We were adding "XXX" that was replaced with "999" before the move to the atomic update files (bug 13068). We do no longer need this code. Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. Read the diff for the patch - looks OK to me. Created attachment 171129 [details] [review] Bug 37818: Remove 'XXX' from the installer code We were adding "XXX" that was replaced with "999" before the move to the atomic update files (bug 13068). We do no longer need this code. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Pushed for 24.11! Well done everyone, thank you! Unfortunately, this broke tests: # Subtest: get_atomic_updates method 1..1 ok 1 - get_atomic_updates returns correct files ok 4 - get_atomic_updates method # Failed test 'TransformToNum('18.05.02.XXX') = '18.0502999'' # at t/db_dependent/Koha/Installer.t line 116. # got: '18.0502XXX' # expected: '18.0502999' # Failed test 'TransformToNum('19.11.02.XXX') = '19.1102999'' # at t/db_dependent/Koha/Installer.t line 116. # got: '19.1102XXX' # expected: '19.1102999' # Looks like you failed 2 tests of 5. # Failed test 'TransformToNum' # at t/db_dependent/Koha/Installer.t line 119. I guess we can just remove these now? Created attachment 171468 [details] [review] Bug 37818: (follow-up) Remove failing XXX tests from Installer.t I've removed the failing XXX related tests and reset the test counter. Doesn't apply clean to 24.05, no backport. |