Summary: | Switch OPAC download list form from POST to GET | ||
---|---|---|---|
Product: | Koha | Reporter: | Phil Ringnalda <phil> |
Component: | OPAC | Assignee: | Phil Ringnalda <phil> |
Status: | RESOLVED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | normal | ||
Priority: | P3 | CC: | chloe.zermatten, fridolin.somers, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.11.00,24.05.06
|
|
Circulation function: | |||
Bug Depends on: | 36192 | ||
Bug Blocks: | 37728 | ||
Attachments: |
Bug 37827: Switch OPAC download list form from POST to GET
Bug 37827: Switch OPAC download list form from POST to GET Bug 37827: Switch OPAC download list form from POST to GET |
Description
Phil Ringnalda
2024-09-04 04:45:48 UTC
Created attachment 171008 [details] [review] Bug 37827: Switch OPAC download list form from POST to GET The hidden form that the OPAC uses for downloading a list has no need to be a POST, which is good because it can't be one without having an op param that starts with "cud-" which it doesn't have. Test plan: 1. Nothing visible will change, so start with the patch applied 2. Log in to the OPAC, then do a search for something like Perl which will return a couple of results. Select two, With selected titles: Add to list - New list - give it a name and Save 3. Lists - choose the one you just created 4. Download - ISBD 5. Verify that the page you were on didn't change, that a file was downloaded, and that the file contains the two titles in your list Sponsored-by: Chetco Community Public Library Created attachment 171016 [details] [review] Bug 37827: Switch OPAC download list form from POST to GET The hidden form that the OPAC uses for downloading a list has no need to be a POST, which is good because it can't be one without having an op param that starts with "cud-" which it doesn't have. Test plan: 1. Nothing visible will change, so start with the patch applied 2. Log in to the OPAC, then do a search for something like Perl which will return a couple of results. Select two, With selected titles: Add to list - New list - give it a name and Save 3. Lists - choose the one you just created 4. Download - ISBD 5. Verify that the page you were on didn't change, that a file was downloaded, and that the file contains the two titles in your list Sponsored-by: Chetco Community Public Library Signed-off-by: Chloe Zermatten <chloe.zermatten@ptfs-europe.com> Created attachment 171325 [details] [review] Bug 37827: Switch OPAC download list form from POST to GET The hidden form that the OPAC uses for downloading a list has no need to be a POST, which is good because it can't be one without having an op param that starts with "cud-" which it doesn't have. Test plan: 1. Nothing visible will change, so start with the patch applied 2. Log in to the OPAC, then do a search for something like Perl which will return a couple of results. Select two, With selected titles: Add to list - New list - give it a name and Save 3. Lists - choose the one you just created 4. Download - ISBD 5. Verify that the page you were on didn't change, that a file was downloaded, and that the file contains the two titles in your list Sponsored-by: Chetco Community Public Library Signed-off-by: Chloe Zermatten <chloe.zermatten@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.06 Not for 23.11.x Nothing to document, just an invisible bugfix. |