Bug 37827 - Switch OPAC download list form from POST to GET
Summary: Switch OPAC download list form from POST to GET
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P3 normal
Assignee: Phil Ringnalda
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on: 36192
Blocks: 37728
  Show dependency treegraph
 
Reported: 2024-09-04 04:45 UTC by Phil Ringnalda
Modified: 2024-09-13 10:08 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 37827: Switch OPAC download list form from POST to GET (1.78 KB, patch)
2024-09-04 04:52 UTC, Phil Ringnalda
Details | Diff | Splinter Review
Bug 37827: Switch OPAC download list form from POST to GET (1.84 KB, patch)
2024-09-04 10:42 UTC, Chloe Zermatten
Details | Diff | Splinter Review
Bug 37827: Switch OPAC download list form from POST to GET (1.92 KB, patch)
2024-09-11 13:51 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Phil Ringnalda 2024-09-04 04:45:48 UTC
We meant to not have any forms that post without an op starting with cud-, but because of bug 37728 we missed a few, like the hidden form to download a list in the OPAC.

There's no visible reason why it even needs a form to submit, rather than just having the menu be a list of links the way the staff client does it, but that's a problem for another bug. Here, we just need to switch it from a post to a get, so we can land the fix to the test for things posting without a cud- op.
Comment 1 Phil Ringnalda 2024-09-04 04:52:55 UTC
Created attachment 171008 [details] [review]
Bug 37827: Switch OPAC download list form from POST to GET

The hidden form that the OPAC uses for downloading a list has no need to be
a POST, which is good because it can't be one without having an op param
that starts with "cud-" which it doesn't have.

Test plan:
1. Nothing visible will change, so start with the patch applied
2. Log in to the OPAC, then do a search for something like Perl which will
   return a couple of results. Select two, With selected titles: Add to
   list - New list - give it a name and Save
3. Lists - choose the one you just created
4. Download - ISBD
5. Verify that the page you were on didn't change, that a file was downloaded,
   and that the file contains the two titles in your list

Sponsored-by: Chetco Community Public Library
Comment 2 Chloe Zermatten 2024-09-04 10:42:43 UTC
Created attachment 171016 [details] [review]
Bug 37827: Switch OPAC download list form from POST to GET

The hidden form that the OPAC uses for downloading a list has no need to be
a POST, which is good because it can't be one without having an op param
that starts with "cud-" which it doesn't have.

Test plan:
1. Nothing visible will change, so start with the patch applied
2. Log in to the OPAC, then do a search for something like Perl which will
   return a couple of results. Select two, With selected titles: Add to
   list - New list - give it a name and Save
3. Lists - choose the one you just created
4. Download - ISBD
5. Verify that the page you were on didn't change, that a file was downloaded,
   and that the file contains the two titles in your list

Sponsored-by: Chetco Community Public Library
Signed-off-by: Chloe Zermatten <chloe.zermatten@ptfs-europe.com>
Comment 3 Jonathan Druart 2024-09-11 13:51:43 UTC
Created attachment 171325 [details] [review]
Bug 37827: Switch OPAC download list form from POST to GET

The hidden form that the OPAC uses for downloading a list has no need to be
a POST, which is good because it can't be one without having an op param
that starts with "cud-" which it doesn't have.

Test plan:
1. Nothing visible will change, so start with the patch applied
2. Log in to the OPAC, then do a search for something like Perl which will
   return a couple of results. Select two, With selected titles: Add to
   list - New list - give it a name and Save
3. Lists - choose the one you just created
4. Download - ISBD
5. Verify that the page you were on didn't change, that a file was downloaded,
   and that the file contains the two titles in your list

Sponsored-by: Chetco Community Public Library
Signed-off-by: Chloe Zermatten <chloe.zermatten@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Katrin Fischer 2024-09-13 10:08:07 UTC
Pushed for 24.11!

Well done everyone, thank you!