Summary: | Rental discount is should be decimal like other similar fields in circulation rules | ||
---|---|---|---|
Product: | Koha | Reporter: | Peter Vashchuk <stalkernoid> |
Component: | Circulation | Assignee: | Peter Vashchuk <stalkernoid> |
Status: | Pushed to main --- | QA Contact: | Lisette Scheer <lisette> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt, kyle.m.hall, lisette, ovezina |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
25.05.00
|
|
Circulation function: | |||
Attachments: |
Bug 37832: Fix Rentaldiscount to be decimal like other similar fields
Bug 37832: Fix Rentaldiscount to be decimal like other similar fields Attachment to Bug 37832 - Rentaldiscount is not required to be decimal like other similar fields in smart-rules.tt |
Description
Peter Vashchuk
2024-09-04 13:45:30 UTC
Created attachment 171028 [details] [review] Bug 37832: Fix Rentaldiscount to be decimal like other similar fields Added decimal input_mode and pattern for "Rental discount (%)" so it functions same way as "Fine amount" or "Overdue fines cap (amount)" rules, allowing user to save decimals only. 1. Go to Circulation and fine rules page and save some gibberish into "Rental discount (%)", see that it allows you to do that. 2. Apply the patch, and try same thing again, this time it should only allow you to save decimal numbers. Created attachment 171495 [details] [review] Bug 37832: Fix Rentaldiscount to be decimal like other similar fields Added decimal input_mode and pattern for "Rental discount (%)" so it functions same way as "Fine amount" or "Overdue fines cap (amount)" rules, allowing user to save decimals only. 1. Go to Circulation and fine rules page and save some gibberish into "Rental discount (%)", see that it allows you to do that. 2. Apply the patch, and try same thing again, this time it should only allow you to save decimal numbers. Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Created attachment 176240 [details] [review] Attachment to Bug 37832 - Rentaldiscount is not required to be decimal like other similar fields in smart-rules.tt Bug 37832: Fix Rentaldiscount to be decimal like other similar fields Added decimal input_mode and pattern for "Rental discount (%)" so it functions same way as "Fine amount" or "Overdue fines cap (amount)" rules, allowing user to save decimals only. 1. Go to Circulation and fine rules page and save some gibberish into "Rental discount (%)", see that it allows you to do that. 2. Apply the patch, and try same thing again, this time it should only allow you to save decimal numbers. Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Pushed for 25.05! Well done everyone, thank you! |