Created attachment 171028 [details] [review] Bug 37832: Fix Rentaldiscount to be decimal like other similar fields Added decimal input_mode and pattern for "Rental discount (%)" so it functions same way as "Fine amount" or "Overdue fines cap (amount)" rules, allowing user to save decimals only. 1. Go to Circulation and fine rules page and save some gibberish into "Rental discount (%)", see that it allows you to do that. 2. Apply the patch, and try same thing again, this time it should only allow you to save decimal numbers.
Created attachment 171495 [details] [review] Bug 37832: Fix Rentaldiscount to be decimal like other similar fields Added decimal input_mode and pattern for "Rental discount (%)" so it functions same way as "Fine amount" or "Overdue fines cap (amount)" rules, allowing user to save decimals only. 1. Go to Circulation and fine rules page and save some gibberish into "Rental discount (%)", see that it allows you to do that. 2. Apply the patch, and try same thing again, this time it should only allow you to save decimal numbers. Signed-off-by: Olivier V <olivier.vezina@inLibro.com>
Created attachment 176240 [details] [review] Attachment to Bug 37832 - Rentaldiscount is not required to be decimal like other similar fields in smart-rules.tt Bug 37832: Fix Rentaldiscount to be decimal like other similar fields Added decimal input_mode and pattern for "Rental discount (%)" so it functions same way as "Fine amount" or "Overdue fines cap (amount)" rules, allowing user to save decimals only. 1. Go to Circulation and fine rules page and save some gibberish into "Rental discount (%)", see that it allows you to do that. 2. Apply the patch, and try same thing again, this time it should only allow you to save decimal numbers. Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Pushed for 25.05! Well done everyone, thank you!