Bug 37838

Summary: Remove button broken on second page of course reserves item results
Product: Koha Reporter: Wainui Witika-Park <wainuiwitikapark>
Component: Course reservesAssignee: Wainui Witika-Park <wainuiwitikapark>
Status: Needs documenting --- QA Contact: Laura Escamilla <Laura.escamilla>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, Laura.escamilla, lucas, sam.sowanick, wainuiwitikapark
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06
Circulation function:
Attachments: ktd examples of barcodes you can batch add to a course
Bug 37838: Fix broken remove button in course reserves
Bug 37838: Fix broken remove button in course reserves
Bug 37838: Fix broken remove button in course reserves

Description Wainui Witika-Park 2024-09-05 04:35:45 UTC
Created attachment 171044 [details]
ktd examples of barcodes you can batch add to a course

To recreate:

- Go to staff client -> Course reserves
- Create a course or go to an existing course
- Add reserves to the course (will need at least 21 items to be able to go to a second page of results)
- Go to the second page of results on the course details page
- Click the Remove button next to a result
- Notice how the button just makes the page move to the top
Comment 1 Wainui Witika-Park 2024-09-10 03:09:47 UTC
Created attachment 171239 [details] [review]
Bug 37838: Fix broken remove button in course reserves

To test:
1) Go to staff client -> Course reserves
2) Create a course or go to an existing course
3) Add reserves to the course (will need at least 21 items to be able to go to a second page of results)
4) Go to the second page of results on the course details page
5) Click the Remove button next to a result
6) Notice how the button just makes the page move to the top
7) Apply patch
8) Repeat steps 1-5
9) Notice how the remove button is working as expected

Sponsored-by: Toi Ohomai Institute of Technology
Comment 2 Biblibre Sandboxes 2024-09-11 19:16:40 UTC
Created attachment 171354 [details] [review]
Bug 37838: Fix broken remove button in course reserves

To test:
1) Go to staff client -> Course reserves
2) Create a course or go to an existing course
3) Add reserves to the course (will need at least 21 items to be able to go to a second page of results)
4) Go to the second page of results on the course details page
5) Click the Remove button next to a result
6) Notice how the button just makes the page move to the top
7) Apply patch
8) Repeat steps 1-5
9) Notice how the remove button is working as expected

Sponsored-by: Toi Ohomai Institute of Technology
Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Comment 3 Laura Escamilla 2024-09-19 20:23:27 UTC
Created attachment 171805 [details] [review]
Bug 37838: Fix broken remove button in course reserves

To test:
1) Go to staff client -> Course reserves
2) Create a course or go to an existing course
3) Add reserves to the course (will need at least 21 items to be able to go to a second page of results)
4) Go to the second page of results on the course details page
5) Click the Remove button next to a result
6) Notice how the button just makes the page move to the top
7) Apply patch
8) Repeat steps 1-5
9) Notice how the remove button is working as expected

Sponsored-by: Toi Ohomai Institute of Technology
Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Comment 4 Katrin Fischer 2024-10-16 15:35:10 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 5 Lucas Gass (lukeg) 2024-11-18 23:26:27 UTC
Backported to 24.05.x for upcoming 24.05.06
Comment 6 Fridolin Somers 2024-12-11 15:26:58 UTC
Conflicts on 23.11.x
I needed ?
Comment 7 Wainui Witika-Park 2025-01-21 01:00:38 UTC
(In reply to Fridolin Somers from comment #6)
> Conflicts on 23.11.x
> I needed ?

Up to you, I can rebase for 23.11 if you'd like?
Comment 8 Fridolin Somers 2025-01-23 10:53:24 UTC
(In reply to Wainui Witika-Park from comment #7)
> (In reply to Fridolin Somers from comment #6)
> > Conflicts on 23.11.x
> > I needed ?
> 
> Up to you, I can rebase for 23.11 if you'd like?

yes please
Comment 9 Wainui Witika-Park 2025-01-24 00:22:01 UTC
(In reply to Fridolin Somers from comment #8)
> (In reply to Wainui Witika-Park from comment #7)
> > (In reply to Fridolin Somers from comment #6)
> > > Conflicts on 23.11.x
> > > I needed ?
> > 
> > Up to you, I can rebase for 23.11 if you'd like?
> 
> yes please

Hi Fridolin,

I tried to recreate it on 23.11 but the error doesn't exist there so you can ignore this bug for 23.11
Comment 10 Fridolin Somers 2025-01-27 10:24:25 UTC
Thanks a lot